[5.2] Fix pagination issue in the latest release #14389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
themsaid
changed the title
|
@themsaid Thank you for quick fix to my PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed in #14387
The issue was caused by this change: https://github.com/laravel/framework/pull/14188/files
if
$totalis evaluated asfalse,$perPage = $perPage ?: $this->model->getPerPage()will never be executed leaving$perPageequal to null if it wasn't provided in the method call.So calling
->paginate()without any arguments, if no results found$perPagewill be equal to null causing a Division By Zero error in LengthAwarePaginator