[5.2] Transaction count cannot be negative

[ashleydw]

As per ->rollback, the $this->transactions should not go into negative values.

If calling ->commit() without an active transaction will cause the next number to be incorrect.

[GrahamCampbell]

I don't think this is correct. If it goes negative, you should not have called it?

[ashleydw]

The logic here replicates that in ->rollback():

framework/src/Illuminate/Database/Connection.php

Line 606 in e8cb617

$this->transactions = max(0, $this->transactions - 1);

The if statements handle cases where developers are incorrectly calling the method (by doing nothing).

[GrahamCampbell]

We should probably throw an exception here instead. During correct usage, this should never be negative.