[5.2] Use DIRECTORY_SEPARATOR to create migrations path #13254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnabialek
changed the title
|
This has broken several tests on Windows because they haven't been updated accordingly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe it should be changed also in many other places but I've changed it only in this place for now.
The problem:
On Windows this could will evaluate to false, because
getMigrationPath()function is using now/as separator but on Windowsdatabase_pathmethod will use DIRECTORY_SEPARATOR what is\for Windows and it might cause unexpected behaviour for users launching code on Windows.I've found this issue today when my colleagues tried to launch code on Windows whereas other developer run it in native Linux or use Homestead so this problem was not experienced by others.