Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Fix adding implicit rules via sometimes() method #12976

Merged
merged 1 commit into from
Apr 25, 2016
Merged

[5.2] Fix adding implicit rules via sometimes() method #12976

merged 1 commit into from
Apr 25, 2016

Conversation

themsaid
Copy link
Member

@themsaid themsaid commented Apr 1, 2016

Originally submitted here #12755

This PR correctly merges validation rules added via sometimes() when the keys are implicit.

@themsaid
Copy link
Member Author

themsaid commented Apr 2, 2016

screen shot 2016-04-02 at 11 24 14 am

@taylorotwell is there a reason why we use this loop? The $attribute in the docblock is defined as string, and no tests calling sometimes with the first parameter as array.

@taylorotwell taylorotwell merged commit f574322 into laravel:5.2 Apr 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants