Custom file formats not supported

[0xVavaldi]

Re-opening this because it's an issue for every application that use non-standard filetypes.
#41960 (comment)_

• Laravel Version: 9.8.1
• PHP Version: 8.1.3
• league/flysystem 3.0.16

Description:

$headers["Content-Type"] = "text/plain";
$headers["Content-Length"] = $file_size;
$headers["Accept-Ranges"] = "bytes";
$headers["Content-Disposition"] = "attachment; filename={$id}.left";
$headers["Content-Range"] = "bytes " . 0 . "-" . ($file_size) . "/" . $file_size;
Storage::disk("localdisk")->download($id.".found", $headers);

Results in the following error:

local.ERROR: Unable to retrieve the mime_type for file at location: 737.found.  {"exception":"[object] (League\\Flysystem\\UnableToRetrieveMetadata(code: 0): Unable to retrieve the mime_type for file at location: 737.found.  at /var/www/hostname/vendor/league/flysystem/src/UnableToRetrieveMetadata.php:49)

I believe this is caused by me having a non-standard extension, which is fine since I provided the content-type in the headers explicitly. But instead I'm getting errors now with my recent upgrade from laravel 8 to laravel 9. Any way to make this work?

[rodrigopedra]

Sent PR #42759 to propose a fix

[henrik9999]

Sent PR #42759 to propose a fix

I don't think your fix really fixes the underlining issue of it not accepting custom file types or being able to set them if I understand yours correctly all it does is fixing it for download but it probably happens everywhere it's using minetype not just download

[rodrigopedra]

Closed PR #42759 in favor of PR #42760 targeting 9.x

[rodrigopedra]

The Illuminate\Filesystem\FilesystemAdapter@mimeType is only called in two other places:

framework/src/Illuminate/Mail/Attachment.php

Line 98 in 2bc1802

->withMime($attachment->mime ?? $storage->mimeType($path));

Where it appears after the null coalesce operator, so it will only be executed if $attachment->mime fails.

And

framework/src/Illuminate/Mail/Mailable.php

Lines 453 to 466 in 2bc1802

	protected function buildDiskAttachments($message)
	{
	foreach ($this->diskAttachments as $attachment) {
	$storage = Container::getInstance()->make(
	FilesystemFactory::class
	)->disk($attachment['disk']);
	$message->attachData(
	$storage->get($attachment['path']),
	$attachment['name'] ?? basename($attachment['path']),
	array_merge(['mime' => $storage->mimeType($attachment['path'])], $attachment['options'])
	);
	}
	}

Which will indeed fail when attaching a custom file format. Will add a commit to address this.

[rodrigopedra]

Sent a different PR #42761 , to address only the mime type method. Thanks for the heads-up

[henrik9999]

Sent a different PR #42761 , to address only the mime type method. Thanks for the heads-up

What would happen if the flysystem driver internally uses mimetype tho then it would still explode there I guess🤔

[rodrigopedra]

Well, as flysystem is a third-party package, my suggestion is to you propose a change on their repo if you believe this behavior should be changed.

Or write some code to contribute with a PR either there or here, I guess 🤔

[henrik9999]

Well, as flysystem is a third-party package, my suggestion is to you propose a change on their repo if you believe this behavior should be changed.

Or write some code to contribute with a PR either there or here, I guess 🤔

There was thephpleague/flysystem#1448 but all that was done was adding phar as a mime type

[driesvints]

Seems like a PR was sent in to resolve the main issues here. Thanks