ServiceProvider autocomplete on $this->app no longer working in a package.

[Voziv]

• Laravel Version: 5.7.9
• PHP Version: 7.2.10-0ubuntu0.18.04.1
• Database Driver & Version: N/A

Description:

In the PR #25830 the phpdoc was changed from the contract to the concrete implemention.

In my laravel package I'm requiring "illuminate/support": "^5.7" in my composer.json. With this update I no longer have any code completion on $this->app in my service providers.

Should I be depending on a different package? Is my laravel package supposed to depend on the whole framework instead?

For now I've worked around by overriding protected $app to add the old phpdoc back in.

From what I understand the reason this change was made is because the concrete implementation has methods that are not in the interface. Should the interface not be updated with the methods that are missing?

Here's my service provider for reference: https://github.com/ratehub/laravel-newrelic/blob/dev/src/RateHub/NewRelic/Providers/NewRelicServiceProvider.php#L27

Steps To Reproduce:

1. Install "illuminate/support": "5.7.9"
2. In PHPStorm create a class that extends from Illuminate/Support/ServiceProvider
   3.. Attempt to autocomplete $this->app

[staudenmeir]

Can we solve this by specifying both the class and the interface?

@var \Illuminate\Contracts\Foundation\Application|\Illuminate\Foundation\Application

[Voziv]

Hmm, yeah that would solve it as well.

[staudenmeir]

That would be a temporary fix until the missing methods get added to the interface.

/cc @TBlindaruk

[TBlindaruk]

@Voziv ,I have created a PR for this

[TBlindaruk]

@Voziv , Changes are merged to 5.7. The issue will be fixed with a next release;

[Voziv]

Thanks!