Validation error message is empty on array of file

[lino10]

Hi, after doing some testing, I think this is a bug.

I have this html

<input type="file" name="images[]">
<input type="file" name="images[]">
.
.
<input type="file" name="images[]">

Form Request's rules

'images.*' => 'mimes:jpeg',
'name' => 'required',

When the file type is not jpeg, it redirects back to the input page. So the validation works, but there's no error message. When I checked the error message bag, it is empty.

Illuminate\Support\ViewErrorBag Object ( [bags:protected] => Array ( ) ) 

I'm using Laravel Framework version 5.2.12

Might be related: #6028

[GrahamCampbell]

Thanks for reporting. Ping @taylorotwell.

[ctf0]

same here, actually anything other than required wont trigger any error, same as on old 4.2
#6649

[lino10]

I have more information.

if the file validation trigerred, the 'old' field form data will be gone too.

So if I input 'name' and got wrong validation on the file, the field name will not be filled the next redirect.

[ctf0]

@lino10 i believe thats because the image validation bug doesn't treat this as a validation error rather its more of just redirect back.

[ctf0]

@lino10 here is a solution i used back in 4.2, give it a try and see if u have any success

if (Input::file('thumb')->getError() != 0) {
                return Redirect::back()
                    ->withInput()
                    ->withErrors(Input::file('thumb')->getErrorMessage());
            }

[lino10]

@ctf0 Hi, I use the Form Request Validation method, how to implement your code using it?
https://laravel.com/docs/5.2/validation#form-request-validation

[ctf0]

@lino10 ah yes, unfortunately that method doesn't give much of choice to customize the pipeline as u want however u can make the validation along with the rules in another class and inject it into ur store method and work on it as usual.

EDIT:
the above will only work with single file upload as with multi, it will give error if no uploaded file found.

[kkiernan]

I am not able to recreate this issue. Form request validation on an array of files seems to work fine for me on a clean install of Laravel 5.2.12. Has this been fixed already? Maybe something else is going on?

[ctf0]

@kkiernan do u get an actual error message (anything other than required) when u get redirected back ?

[kkiernan]

@ctf0 Yes I get all error messages as expected. For example, if I upload a gif for the first image, this is the message bag I receive:

ViewErrorBag {#150 ▼
  #bags: array:1 [▼
    "default" => MessageBag {#151 ▼
      #messages: array:2 [▼
        "images.0" => array:1 [▼
          0 => "The images.0 must be a file of type: jpeg."
        ]
        "name" => array:1 [▼
          0 => "The name field is required."
        ]
      ]
      #format: ":message"
    }
  ]
}

[ctf0]

@kkiernan , Ping @GrahamCampbell

right now am on 5.2.14 and i have the rules as
'photo.*' => 'required|image|min:1|max:4000|mimes:jpeg,bmp,png'
and to test i've chose a gif file with size of 4.3mb,
so i should get 2 validation errors for both the type and size, however am only getting

Validator {#252 ▼
  #translator: Translator {#114 ▶}
  #presenceVerifier: DatabasePresenceVerifier {#141 ▶}
  #container: Application {#2 ▶}
  #failedRules: array:1 [▼
    "photo.0" => array:1 [▼
      "Required" => []
    ]
  ]
  #messages: MessageBag {#253 ▼
    #messages: array:1 [▼
      "photo.0" => array:1 [▼
        0 => "The photo.0 field is required."
      ]
    ]
    #format: ":message"
  }
  #data: array:14 [▶]
  #files: array:1 [▼
    "photo.0" => UploadedFile {#30 ▼
      -test: false
      -originalName: "3o85xpXcGqIX5ALSlG.gif"
      -mimeType: "application/octet-stream"
      -size: 0
      -error: 1
      path: ""
      filename: ""
      basename: ""
      pathname: ""
      extension: ""
      realPath: "/Users/Novo/Public/www/public"
      aTime: 1970-01-01 00:00:00
      mTime: 1970-01-01 00:00:00
      cTime: 1970-01-01 00:00:00
      inode: false
      size: false
      perms: 00
      owner: false
      group: false
      type: false
      writable: false
      readable: false
      executable: false
      file: false
      dir: false
      link: false
    }
  ]
  #rules: array:1 [▼
    "photo.0" => array:5 [▼
      0 => "required"
      1 => "image"
      2 => "min:1"
      3 => "max:4000"
      4 => "mimes:jpeg,bmp,png"
    ]
  ]
  #after: []
  #customMessages: []
  #fallbackMessages: array:2 [▶]
  #customAttributes: []
  #customValues: []
  #extensions: array:2 [▶]
  #replacers: []
  #sizeRules: array:4 [▶]
  #numericRules: array:2 [▶]
  #implicitRules: array:8 [▶]
}

[lino10]

I just tested using the fresh 5.2.14, there's still no error messages. So why is this issue closed?

Here's the app and resources folder, you just need to replace them to test. Just empty the name field and upload image other than gif.
http://s000.tinyupload.com/index.php?file_id=71431977644503943832

Tested using xampp and homestead

[lino10]

I think I know why the error displayed for kkiernan. If you don't use enctype="multipart/form-data" on the form, the error will display.