dont mock console output by default

laravel · Sep 5, 2018 · b433970 · b433970
1 parent 6a8ab13
commit b433970
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 2 deletions.
diff --git a/src/Illuminate/Foundation/Testing/Concerns/InteractsWithConsole.php b/src/Illuminate/Foundation/Testing/Concerns/InteractsWithConsole.php
@@ -2,10 +2,13 @@
 
 namespace Illuminate\Foundation\Testing\Concerns;
 
+use Illuminate\Contracts\Console\Kernel;
 use Illuminate\Foundation\Testing\PendingCommand;
 
 trait InteractsWithConsole
 {
+    protected $mockConsoleOutput = false;
+
     /**
      * All of the expected output lines.
      *
@@ -29,6 +32,10 @@ trait InteractsWithConsole
      */
     public function artisan($command, $parameters = [])
     {
+        if (! $this->mockConsoleOutput) {
+            return $this->app[Kernel::class]->call($command, $parameters);
+        }
+
         $this->beforeApplicationDestroyed(function () {
             if (count($this->expectedQuestions)) {
                 $this->fail('Question "'.array_first($this->expectedQuestions)[0].'" was not asked.');
@@ -41,4 +48,11 @@ public function artisan($command, $parameters = [])
 
         return new PendingCommand($this, $this->app, $command, $parameters);
     }
+
+    protected function withMockedConsoleOutput()
+    {
+        $this->mockConsoleOutput = true;
+
+        return $this;
+    }
 }
diff --git a/tests/Integration/Console/ConsoleApplicationTest.php b/tests/Integration/Console/ConsoleApplicationTest.php
@@ -3,6 +3,7 @@
 namespace Illuminate\Tests\Integration\Console;
 
 use Illuminate\Console\Command;
+use Illuminate\Foundation\Testing\PendingCommand;
 use Orchestra\Testbench\TestCase;
 use Illuminate\Contracts\Console\Kernel;
 
@@ -19,14 +20,27 @@ public function test_artisan_call_using_command_name()
     {
         $exitCode = $this->artisan('foo:bar', [
             'id' => 1,
-        ])->assertExitCode(0);
+        ]);
+
+        $this->assertSame(0, $exitCode);
     }
 
     public function test_artisan_call_using_command_class()
     {
         $exitCode = $this->artisan(FooCommandStub::class, [
             'id' => 1,
-        ])->assertExitCode(0);
+        ]);
+
+        $this->assertSame(0, $exitCode);
+    }
+
+    public function test_artisan_call_using_command_class_with_mocked_output()
+    {
+        $pendingCommand = $this->withMockedConsoleOutput()->artisan(FooCommandStub::class, ['id' => 1]);
+
+        $this->assertInstanceOf(PendingCommand::class, $pendingCommand);
+
+        $pendingCommand->assertExitCode(0);
     }
 }