Skip to content

Commit b31ddd1

Browse files
committed
Add type hinting for lateral join methods
1 parent 021acc9 commit b31ddd1

File tree

5 files changed

+6
-6
lines changed

5 files changed

+6
-6
lines changed

src/Illuminate/Database/Query/Builder.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -594,7 +594,7 @@ public function joinSub($query, $as, $first, $operator = null, $second = null, $
594594
* @param string $type
595595
* @return $this
596596
*/
597-
public function joinLateral($query, $as, $type = 'inner')
597+
public function joinLateral($query, string $as, string $type = 'inner'): static
598598
{
599599
[$query, $bindings] = $this->createSub($query);
600600

@@ -614,7 +614,7 @@ public function joinLateral($query, $as, $type = 'inner')
614614
* @param string $as
615615
* @return $this
616616
*/
617-
public function leftJoinLateral($query, $as)
617+
public function leftJoinLateral($query, string $as): static
618618
{
619619
return $this->joinLateral($query, $as, 'left');
620620
}

src/Illuminate/Database/Query/Grammars/Grammar.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,7 @@ protected function compileJoins(Builder $query, $joins)
199199
*
200200
* @throws \RuntimeException
201201
*/
202-
public function joinLateral(JoinClause $join, string $expression)
202+
public function joinLateral(JoinClause $join, string $expression): string
203203
{
204204
throw new RuntimeException('This database engine does not support lateral joins.');
205205
}

src/Illuminate/Database/Query/Grammars/MySqlGrammar.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -241,7 +241,7 @@ protected function compileUpdateColumns(Builder $query, array $values)
241241
* @param string $expression
242242
* @return string
243243
*/
244-
public function joinLateral(JoinClause $join, string $expression)
244+
public function joinLateral(JoinClause $join, string $expression): string
245245
{
246246
return trim("{$join->type} join lateral {$expression} on true");
247247
}

src/Illuminate/Database/Query/Grammars/PostgresGrammar.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -393,7 +393,7 @@ protected function compileUpdateColumns(Builder $query, array $values)
393393
* @param string $expression
394394
* @return string
395395
*/
396-
public function joinLateral(JoinClause $join, string $expression)
396+
public function joinLateral(JoinClause $join, string $expression): string
397397
{
398398
return trim("{$join->type} join lateral {$expression} on true");
399399
}

src/Illuminate/Database/Query/Grammars/SqlServerGrammar.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -394,7 +394,7 @@ protected function compileUpdateWithJoins(Builder $query, $table, $columns, $whe
394394
* @param string $expression
395395
* @return string
396396
*/
397-
public function joinLateral(JoinClause $join, string $expression)
397+
public function joinLateral(JoinClause $join, string $expression): string
398398
{
399399
$type = $join->type == 'left' ? 'outer' : 'cross';
400400

0 commit comments

Comments
 (0)