[10.x] Allow to pass Arrayable or Stringble in rules In and NotIn (#49055)

* Allow to pass `Arrayable` or `Stringble` in rules `In` and `NotIn`

* Add tests

Author: michaelnabil230

src/Illuminate/Validation/Rules/In.php

@@ -3,6 +3,7 @@
 namespace Illuminate\Validation\Rules;
 
 use BackedEnum;
+use Illuminate\Contracts\Support\Arrayable;
 use UnitEnum;
 
 class In
@@ -24,12 +25,16 @@ class In
     /**
      * Create a new in rule instance.
      *
-     * @param  array  $values
+     * @param  \Illuminate\Contracts\Support\Arrayable|array|string  $values
      * @return void
      */
-    public function __construct(array $values)
+    public function __construct($values)
     {
-        $this->values = $values;
+        if ($values instanceof Arrayable) {
+            $values = $values->toArray();
+        }
+
+        $this->values = is_array($values) ? $values : func_get_args();
     }
 
     /**

src/Illuminate/Validation/Rules/NotIn.php

@@ -3,6 +3,7 @@
 namespace Illuminate\Validation\Rules;
 
 use BackedEnum;
+use Illuminate\Contracts\Support\Arrayable;
 use UnitEnum;
 
 class NotIn
@@ -24,12 +25,16 @@ class NotIn
     /**
      * Create a new "not in" rule instance.
      *
-     * @param  array  $values
+     * @param  \Illuminate\Contracts\Support\Arrayable|array|string  $values
      * @return void
      */
-    public function __construct(array $values)
+    public function __construct($values)
     {
-        $this->values = $values;
+        if ($values instanceof Arrayable) {
+            $values = $values->toArray();
+        }
+
+        $this->values = is_array($values) ? $values : func_get_args();
     }
 
     /**

tests/Validation/ValidationInRuleTest.php

@@ -17,10 +17,22 @@ public function testItCorrectlyFormatsAStringVersionOfTheRule()
 
         $this->assertSame('in:"Laravel","Framework","PHP"', (string) $rule);
 
+        $rule = new In(collect(['Taylor', 'Michael', 'Tim']));
+
+        $this->assertSame('in:"Taylor","Michael","Tim"', (string) $rule);
+
         $rule = new In(['Life, the Universe and Everything', 'this is a "quote"']);
 
         $this->assertSame('in:"Life, the Universe and Everything","this is a ""quote"""', (string) $rule);
 
+        $rule = Rule::in(collect([1, 2, 3, 4]));
+
+        $this->assertSame('in:"1","2","3","4"', (string) $rule);
+
+        $rule = Rule::in(collect([1, 2, 3, 4]));
+
+        $this->assertSame('in:"1","2","3","4"', (string) $rule);
+
         $rule = new In(["a,b\nc,d"]);
 
         $this->assertSame("in:\"a,b\nc,d\"", (string) $rule);
@@ -41,6 +53,10 @@ public function testItCorrectlyFormatsAStringVersionOfTheRule()
 
         $this->assertSame('in:"1","2","3","4"', (string) $rule);
 
+        $rule = new In('1', '2', '3', '4');
+
+        $this->assertSame('in:"1","2","3","4"', (string) $rule);
+
         $rule = Rule::in([StringStatus::done]);
 
         $this->assertSame('in:"done"', (string) $rule);

tests/Validation/ValidationNotInRuleTest.php

@@ -2,6 +2,7 @@
 
 namespace Illuminate\Tests\Validation;
 
+use Illuminate\Tests\Validation\fixtures\Values;
 use Illuminate\Validation\Rule;
 use Illuminate\Validation\Rules\NotIn;
 use PHPUnit\Framework\TestCase;
@@ -16,6 +17,18 @@ public function testItCorrectlyFormatsAStringVersionOfTheRule()
 
         $this->assertSame('not_in:"Laravel","Framework","PHP"', (string) $rule);
 
+        $rule = new NotIn(collect(['Taylor', 'Michael', 'Tim']));
+
+        $this->assertSame('not_in:"Taylor","Michael","Tim"', (string) $rule);
+
+        $rule = Rule::notIn(collect([1, 2, 3, 4]));
+
+        $this->assertSame('not_in:"1","2","3","4"', (string) $rule);
+
+        $rule = Rule::notIn(collect([1, 2, 3, 4]));
+
+        $this->assertSame('not_in:"1","2","3","4"', (string) $rule);
+
         $rule = Rule::notIn([1, 2, 3, 4]);
 
         $this->assertSame('not_in:"1","2","3","4"', (string) $rule);
@@ -24,10 +37,22 @@ public function testItCorrectlyFormatsAStringVersionOfTheRule()
 
         $this->assertSame('not_in:"1","2","3","4"', (string) $rule);
 
+        $rule = Rule::notIn(new Values);
+
+        $this->assertSame('not_in:"1","2","3","4"', (string) $rule);
+
+        $rule = new NotIn(new Values);
+
+        $this->assertSame('not_in:"1","2","3","4"', (string) $rule);
+
         $rule = Rule::notIn('1', '2', '3', '4');
 
         $this->assertSame('not_in:"1","2","3","4"', (string) $rule);
 
+        $rule = new NotIn('1', '2', '3', '4');
+
+        $this->assertSame('not_in:"1","2","3","4"', (string) $rule);
+
         $rule = Rule::notIn([StringStatus::done]);
 
         $this->assertSame('not_in:"done"', (string) $rule);