[11.x] Fix modifying columns with default value and other minor schema enhancements (#49897)

* add support for srid on mariadb

* fix modifying a column with default

* fix renaming a column with default on lagacy mysql

* use getTableListing

* fix phpdoc on column definition

* use getServerVersion

* formatting

Author: hafezdivandari

src/Illuminate/Database/Query/Grammars/MySqlGrammar.php

@@ -4,7 +4,6 @@
 
 use Illuminate\Database\Query\Builder;
 use Illuminate\Support\Str;
-use PDO;
 
 class MySqlGrammar extends Grammar
 {
@@ -116,7 +115,7 @@ protected function compileGroupLimit(Builder $query)
      */
     public function useLegacyGroupLimit(Builder $query)
     {
-        $version = $query->getConnection()->getReadPdo()->getAttribute(PDO::ATTR_SERVER_VERSION);
+        $version = $query->getConnection()->getServerVersion();
 
         return ! $query->getConnection()->isMaria() && version_compare($version, '8.0.11') < 0;
     }

src/Illuminate/Database/Query/Grammars/SQLiteGrammar.php

@@ -5,7 +5,6 @@
 use Illuminate\Database\Query\Builder;
 use Illuminate\Support\Arr;
 use Illuminate\Support\Str;
-use PDO;
 
 class SQLiteGrammar extends Grammar
 {
@@ -193,7 +192,7 @@ protected function compileJsonContainsKey($column)
      */
     protected function compileGroupLimit(Builder $query)
     {
-        $version = $query->getConnection()->getReadPdo()->getAttribute(PDO::ATTR_SERVER_VERSION);
+        $version = $query->getConnection()->getServerVersion();
 
         if (version_compare($version, '3.25.0') >= 0) {
             return parent::compileGroupLimit($query);

src/Illuminate/Database/Schema/ColumnDefinition.php

@@ -10,7 +10,7 @@
  * @method $this autoIncrement() Set INTEGER columns as auto-increment (primary key)
  * @method $this change() Change the column
  * @method $this charset(string $charset) Specify a character set for the column (MySQL)
- * @method $this collation(string $collation) Specify a collation for the column (MySQL/PostgreSQL/SQL Server)
+ * @method $this collation(string $collation) Specify a collation for the column
  * @method $this comment(string $comment) Add a comment to the column (MySQL/PostgreSQL)
  * @method $this default(mixed $value) Specify a "default" value for the column
  * @method $this first() Place the column "first" in the table (MySQL)

src/Illuminate/Database/Schema/Grammars/MySqlGrammar.php

@@ -327,7 +327,9 @@ public function compileRenameColumn(Blueprint $blueprint, Fluent $command, Conne
                     default => $column['type_name'],
                 },
                 'nullable' => $column['nullable'],
-                'default' => $column['default'],
+                'default' => $column['default'] && str_starts_with(strtolower($column['default']), 'current_timestamp')
+                    ? new Expression($column['default'])
+                    : $column['default'],
                 'autoIncrement' => $column['auto_increment'],
                 'collation' => $column['collation'],
                 'comment' => $column['comment'],
@@ -1039,7 +1041,11 @@ protected function typeGeometry(Fluent $column)
 
         return sprintf('%s%s',
             $subtype ?? 'geometry',
-            $column->srid ? ' srid '.$column->srid : ''
+            match (true) {
+                $column->srid && $this->connection?->isMaria() => ' ref_system_id='.$column->srid,
+                (bool) $column->srid => ' srid '.$column->srid,
+                default => '',
+            }
         );
     }
 

src/Illuminate/Database/Schema/Grammars/SQLiteGrammar.php

@@ -264,7 +264,7 @@ public function compileChange(Blueprint $blueprint, Fluent $command, Connection
                             'change' => true,
                             'type' => $column['type_name'],
                             'nullable' => $column['nullable'],
-                            'default' => $column['default'],
+                            'default' => $column['default'] ? new Expression($column['default']) : null,
                             'autoIncrement' => $column['auto_increment'],
                             'collation' => $column['collation'],
                             'comment' => $column['comment'],

src/Illuminate/Foundation/Testing/DatabaseTruncation.php

@@ -83,7 +83,7 @@ protected function truncateTablesForConnection(ConnectionInterface $connection,
 
         $connection->unsetEventDispatcher();
 
-        collect(static::$allTables[$name] ??= array_column($connection->getSchemaBuilder()->getTables(), 'name'))
+        collect(static::$allTables[$name] ??= $connection->getSchemaBuilder()->getTableListing())
             ->when(
                 property_exists($this, 'tablesToTruncate'),
                 fn ($tables) => $tables->intersect($this->tablesToTruncate),

tests/Integration/Database/DatabaseSchemaBlueprintTest.php

@@ -320,6 +320,31 @@ public function testChangingDoubleColumnsWork()
         $this->assertEquals($expected, $queries);
     }
 
+    public function testChangingColumnsWithDefaultWorks()
+    {
+        DB::connection()->getSchemaBuilder()->create('products', function (Blueprint $table) {
+            $table->integer('changed_col');
+            $table->timestamp('timestamp_col')->useCurrent();
+            $table->integer('integer_col')->default(123);
+            $table->string('string_col')->default('value');
+        });
+
+        $blueprint = new Blueprint('products', function ($table) {
+            $table->text('changed_col')->change();
+        });
+
+        $queries = $blueprint->toSql(DB::connection(), new SQLiteGrammar);
+
+        $expected = [
+            'create table "__temp__products" ("changed_col" text not null, "timestamp_col" datetime not null default CURRENT_TIMESTAMP, "integer_col" integer not null default \'123\', "string_col" varchar not null default \'value\')',
+            'insert into "__temp__products" ("changed_col", "timestamp_col", "integer_col", "string_col") select "changed_col", "timestamp_col", "integer_col", "string_col" from "products"',
+            'drop table "products"',
+            'alter table "__temp__products" rename to "products"',
+        ];
+
+        $this->assertEquals($expected, $queries);
+    }
+
     public function testRenameIndexWorks()
     {
         DB::connection()->getSchemaBuilder()->create('users', function ($table) {

tests/Integration/Database/SchemaBuilderTest.php

@@ -111,6 +111,26 @@ public function testChangeTextColumnToTextColumn()
         }
     }
 
+    public function testRenameColumnWithDefault()
+    {
+        Schema::create('test', static function (Blueprint $table) {
+            $table->timestamp('foo')->useCurrent();
+            $table->string('bar')->default('value');
+        });
+
+        $columns = Schema::getColumns('test');
+        $defaultFoo = collect($columns)->firstWhere('name', 'foo')['default'];
+        $defaultBar = collect($columns)->firstWhere('name', 'bar')['default'];
+
+        Schema::table('test', static function (Blueprint $table) {
+            $table->renameColumn('foo', 'new_foo');
+            $table->renameColumn('bar', 'new_bar');
+        });
+
+        $this->assertEquals(collect(Schema::getColumns('test'))->firstWhere('name', 'new_foo')['default'], $defaultFoo);
+        $this->assertEquals(collect(Schema::getColumns('test'))->firstWhere('name', 'new_bar')['default'], $defaultBar);
+    }
+
     public function testGetTables()
     {
         Schema::create('foo', function (Blueprint $table) {