refactor: Some minor performance & readability enhancements (#53596)

Author: dshafik

src/Illuminate/Bus/Dispatcher.php

@@ -109,9 +109,7 @@ public function dispatchNow($command, $handler = null)
     {
         $uses = class_uses_recursive($command);
 
-        if (in_array(InteractsWithQueue::class, $uses) &&
-            in_array(Queueable::class, $uses) &&
-            ! $command->job) {
+        if (isset($uses[InteractsWithQueue::class], $uses[Queueable::class]) && ! $command->job) {
             $command->setJob(new SyncJob($this->container, json_encode([]), 'sync', 'sync'));
         }
 
@@ -217,7 +215,7 @@ public function dispatchToQueue($command)
     {
         $connection = $command->connection ?? null;
 
-        $queue = call_user_func($this->queueResolver, $connection);
+        $queue = ($this->queueResolver)($connection);
 
         if (! $queue instanceof Queue) {
             throw new RuntimeException('Queue resolver did not return a Queue implementation.');
@@ -239,19 +237,11 @@ public function dispatchToQueue($command)
      */
     protected function pushCommandToQueue($queue, $command)
     {
-        if (isset($command->queue, $command->delay)) {
-            return $queue->laterOn($command->queue, $command->delay, $command);
-        }
-
-        if (isset($command->queue)) {
-            return $queue->pushOn($command->queue, $command);
-        }
-
         if (isset($command->delay)) {
-            return $queue->later($command->delay, $command);
+            return $queue->later($command->delay, $command, queue: $command->queue ?? null);
         }
 
-        return $queue->push($command);
+        return $queue->push($command, queue: $command->queue ?? null);
     }
 
     /**

tests/Bus/BusDispatcherTest.php

@@ -51,7 +51,7 @@ public function testCommandsThatShouldQueueIsQueuedUsingCustomQueueAndDelay()
         $container = new Container;
         $dispatcher = new Dispatcher($container, function () {
             $mock = m::mock(Queue::class);
-            $mock->shouldReceive('laterOn')->once()->with('foo', 10, m::type(BusDispatcherTestSpecificQueueAndDelayCommand::class));
+            $mock->shouldReceive('later')->once()->with(10, m::type(BusDispatcherTestSpecificQueueAndDelayCommand::class), '', 'foo');
 
             return $mock;
         });