fix: apply packagist changes to GithubStrategy (#5)

Author: shyim

src/Strategy/GithubStrategy.php

@@ -101,7 +101,7 @@ public function getCurrentRemoteVersion(Updater $updater)
             );
         }
 
-        $versions = array_keys($package['packages'][$this->getPackageName()]);
+        $versions = array_column($package['packages'][$this->getPackageName()], 'version');
         $versionParser = new VersionParser($versions);
         if ($this->getStability() === self::STABLE) {
             $this->remoteVersion = $versionParser->getMostRecentStable();
@@ -115,7 +115,11 @@ public function getCurrentRemoteVersion(Updater $updater)
          * Setup remote URL if there's an actual version to download.
          */
         if (! empty($this->remoteVersion)) {
-            $this->remoteUrl = $this->getDownloadUrl($package);
+            $chosenVersion = array_filter($package['packages'][$this->getPackageName()], function (array $package) {
+                return $package['version'] === $this->remoteVersion;
+            })[0];
+
+            $this->remoteUrl = $this->getDownloadUrl($chosenVersion);
         }
 
         return $this->remoteVersion;
@@ -218,15 +222,14 @@ protected function getDownloadUrl(array $package)
         $baseUrl = preg_replace(
             '{\.git$}',
             '',
-            $package['packages'][$this->getPackageName()][$this->remoteVersion]['source']['url']
+            $package['source']['url']
         );
-        $downloadUrl = sprintf(
+
+        return sprintf(
             '%s/releases/download/%s/%s',
             $baseUrl,
             $this->remoteVersion,
             $this->getPharName()
         );
-
-        return $downloadUrl;
     }
 }

tests/Humbug/Test/SelfUpdate/UpdaterGithubStrategyTest.php

@@ -139,12 +139,14 @@ private function createTestPharAndKey(): void
         file_put_contents($this->tmp.'/packages.json', json_encode([
             'packages' => [
                 'humbug/test-phar' => [
-                    '1.0.1' => [
+                    [
+                        'version' => '1.0.1',
                         'source' => [
                             'url' => 'file://'.$this->tmp.'.git',
                         ],
                     ],
-                    '1.0.0' => [
+                    [
+                        'version' => '1.0.0',
                     ],
                 ],
             ],