Ensure enum type is used in factory (#724)

Author: benjam-es

src/Generators/FactoryGenerator.php

@@ -120,7 +120,7 @@ protected function buildDefinition(Model $model): string
                 $definition .= sprintf('%s::factory()', $class);
                 $definition .= ',' . PHP_EOL;
             } elseif (in_array($column->dataType(), ['enum', 'set']) && !empty($column->attributes())) {
-                $faker = FakerRegistry::fakerData($column->name()) ?? FakerRegistry::fakerDataType($column->dataType());
+                $faker = FakerRegistry::fakerDataType($column->dataType()) ?? FakerRegistry::fakerData($column->name());
                 $definition .= str_repeat(self::INDENT, 3) . "'{$column->name()}' => ";
                 $definition .= '$this->faker->' . $faker;
                 $definition .= ',' . PHP_EOL;

tests/Feature/Generators/FactoryGeneratorTest.php

@@ -166,6 +166,26 @@ public function output_creates_directory_for_nested_components(): void
         $this->assertEquals(['created' => ['database/factories/Admin/UserFactory.php']], $this->subject->output($tree));
     }
 
+    #[Test]
+    public function output_factory_uses_enum(): void
+    {
+        $this->filesystem->expects('stub')
+            ->with($this->factoryStub)
+            ->andReturn($this->stub($this->factoryStub));
+
+        $this->filesystem->expects('exists')
+            ->with('database/factories')
+            ->andReturnTrue();
+
+        $this->filesystem->expects('put')
+            ->with('database/factories/PostFactory.php', $this->fixture('factories/with-enum.php'));
+
+        $tokens = $this->blueprint->parse($this->fixture('drafts/with-enum.yaml'));
+        $tree = $this->blueprint->analyze($tokens);
+
+        $this->assertEquals(['created' => ['database/factories/PostFactory.php']], $this->subject->output($tree));
+    }
+
     public static function modelTreeDataProvider(): array
     {
         return [

tests/fixtures/drafts/with-enum.yaml

@@ -0,0 +1,3 @@
+models:
+  Post:
+    name: enum:one,two,three

tests/fixtures/factories/with-enum.php

@@ -0,0 +1,27 @@
+<?php
+
+namespace Database\Factories;
+
+use Illuminate\Database\Eloquent\Factories\Factory;
+use Illuminate\Support\Str;
+use App\Models\Post;
+
+class PostFactory extends Factory
+{
+    /**
+     * The name of the factory's corresponding model.
+     *
+     * @var string
+     */
+    protected $model = Post::class;
+
+    /**
+     * Define the model's default state.
+     */
+    public function definition(): array
+    {
+        return [
+            'name' => $this->faker->randomElement(["one","two","three"]),
+        ];
+    }
+}