Ability to specify default includes if the client did not send any include #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindyhopchris
requested changes
Apr 23, 2021
Contributor
There was a problem hiding this comment.
Very little to update on this before it can be merged.
To pull in my core changes, use:
composer require laravel-json-api/core:^1.0.0-beta.3That will bring in the develop branch.
Basically update all the controller actions so that they use the static make() method on the response, rather than doing (new DataResponse). Use the withQueryParameters() method on the response. I've put an example in one of the comments.
You also need to ensure that this change is made to all controller actions, i.e. you've missed the relationship actions.
lindyhopchris
approved these changes
Apr 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #74
Depends on laravel-json-api/core#5 getting merged/tagged first