fix: remove deprecation notices in PHP 8.4

Author: lindyhopchris

.github/workflows/tests.yml

@@ -14,7 +14,7 @@ jobs:
     strategy:
       fail-fast: true
       matrix:
-        php: [8.2, 8.3]
+        php: [8.2, 8.3, 8.4]
         laravel: [11]
 
     steps:

CHANGELOG.md

@@ -5,6 +5,10 @@ All notable changes to this project will be documented in this file. This projec
 
 ## Unreleased
 
+### Fixed
+
+- Remove deprecation notices in PHP 8.4.
+
 ## [4.3.1] - 2024-10-31
 
 ### Fixed

composer.json

@@ -27,7 +27,7 @@
         "ext-json": "*",
         "illuminate/database": "^11.0",
         "illuminate/support": "^11.0",
-        "laravel-json-api/core": "^4.0"
+        "laravel-json-api/core": "^4.3.2"
     },
     "require-dev": {
         "orchestra/testbench": "^9.0",

phpunit.xml

@@ -13,6 +13,7 @@
          failOnWarning="true"
          failOnDeprecation="true"
          failOnNotice="true"
+         displayDetailsOnTestsThatTriggerDeprecations="true"
 >
     <coverage/>
     <testsuites>

src/Fields/ArrayHash.php

@@ -55,7 +55,7 @@ class ArrayHash extends Attribute
      * @param string|null $column
      * @return ArrayHash
      */
-    public static function make(string $fieldName, string $column = null): self
+    public static function make(string $fieldName, ?string $column = null): self
     {
         return new self($fieldName, $column);
     }

src/Fields/ArrayList.php

@@ -30,7 +30,7 @@ class ArrayList extends Attribute
      * @param string|null $column
      * @return ArrayList
      */
-    public static function make(string $fieldName, string $column = null): self
+    public static function make(string $fieldName, ?string $column = null): self
     {
         return new self($fieldName, $column);
     }

src/Fields/Attribute.php

@@ -91,7 +91,7 @@ abstract protected function assertValue($value): void;
      * @param string $fieldName
      * @param string|null $column
      */
-    public function __construct(string $fieldName, string $column = null)
+    public function __construct(string $fieldName, ?string $column = null)
     {
         if (empty($fieldName)) {
             throw new InvalidArgumentException('Expecting a non-empty string field name.');

src/Fields/Boolean.php

@@ -21,7 +21,7 @@ class Boolean extends Attribute
      * @param string|null $column
      * @return Boolean
      */
-    public static function make(string $fieldName, string $column = null): self
+    public static function make(string $fieldName, ?string $column = null): self
     {
         return new self($fieldName, $column);
     }

src/Fields/DateTime.php

@@ -37,7 +37,7 @@ class DateTime extends Attribute
      * @param string|null $column
      * @return static
      */
-    public static function make(string $fieldName, string $column = null): self
+    public static function make(string $fieldName, ?string $column = null): self
     {
         return new static($fieldName, $column);
     }

src/Fields/ID.php

@@ -36,7 +36,7 @@ class ID implements IDContract, Fillable
      * @param string|null $column
      * @return static
      */
-    public static function make(string $column = null): self
+    public static function make(?string $column = null): self
     {
         return new static($column);
     }
@@ -46,7 +46,7 @@ public static function make(string $column = null): self
      *
      * @param string|null $column
      */
-    public function __construct(string $column = null)
+    public function __construct(?string $column = null)
     {
         $this->column = $column ?: null;
         $this->sortable();