Skip to content

Commit b8a6887

Browse files
committed
improves computed type by adding a Verbs enum
1 parent 17caacf commit b8a6887

File tree

3 files changed

+23
-18
lines changed

3 files changed

+23
-18
lines changed

src/App/Enums/Types.php

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -10,21 +10,4 @@ class Types extends Enum
1010
public const Write = 'Write';
1111
public const Delete = 'Delete';
1212
public const Link = 'Link';
13-
14-
protected static function data(): array
15-
{
16-
return [
17-
'Read' => self::Read,
18-
'Write' => self::Write,
19-
'Delete' => self::Delete,
20-
'Link' => self::Link,
21-
'HEAD' => self::Read,
22-
'OPTIONS' => self::Read,
23-
'GET' => self::Read,
24-
'POST' => self::Write,
25-
'PATCH' => self::Write,
26-
'PUT' => self::Write,
27-
'DELETE' => self::Delete,
28-
];
29-
}
3013
}

src/App/Enums/Verbs.php

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
<?php
2+
3+
namespace LaravelEnso\Permissions\App\Enums;
4+
5+
use LaravelEnso\Enums\App\Services\Enum;
6+
7+
class Verbs extends Enum
8+
{
9+
protected static function data(): array
10+
{
11+
return [
12+
'HEAD' => Types::Read,
13+
'OPTIONS' => Types::Read,
14+
'GET' => Types::Read,
15+
'POST' => Types::Write,
16+
'PATCH' => Types::Write,
17+
'PUT' => Types::Write,
18+
'DELETE' => Types::Delete,
19+
];
20+
}
21+
}

src/App/Models/Permission.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
use Illuminate\Support\Facades\Route;
77
use LaravelEnso\Menus\App\Models\Menu;
88
use LaravelEnso\Permissions\App\Enums\Types;
9+
use LaravelEnso\Permissions\App\Enums\Verbs;
910
use LaravelEnso\Permissions\App\Exceptions\Permission as Exception;
1011
use LaravelEnso\Roles\App\Models\Role;
1112
use LaravelEnso\Roles\App\Traits\HasRoles;
@@ -42,7 +43,7 @@ public function getTypeAttribute()
4243

4344
public function type()
4445
{
45-
return Types::get($this->method()) ?? Types::Link;
46+
return Verbs::get($this->method()) ?? Types::Link;
4647
}
4748

4849
public function method()

0 commit comments

Comments
 (0)