-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: Bugs in center tap transformer model #407
FIX: Bugs in center tap transformer model #407
Conversation
Updated linear formulations
Codecov Report
@@ Coverage Diff @@
## main #407 +/- ##
==========================================
+ Coverage 70.14% 71.37% +1.23%
==========================================
Files 59 59
Lines 14831 15084 +253
==========================================
+ Hits 10403 10766 +363
+ Misses 4428 4318 -110
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noted some places where some comments should be added in code to signify what that code is used for (to make it easier to find these places in the future).
I also recommend adding a page to the manual as a technical note about center-tap transformers and how we are modeling loads / generators connected to them
…ormulations (FOT, FBS, LinDist3Flow)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some additional comments about documentation. Something I am trying to going forward is to have mathematical representations of the constraints in docstrings, because going back to fix it is very difficult / time consuming, so that's where a lot of the comments are coming from.
One additional question: in the dss2eng conversion, PVSystems, Loads, and Transformers all have special handling, but what about Generators, and Storage? It seems to me that those objects would exist on the customer side as well (diesel generators, battery backups), so should be supported?
This PR fixes the following bugs in center-tapped transformer model:
[4,2]
to introduce the 180 degree phase shift at the node with terminal[2]
.1
even if transformer was not connected to terminal[1]
. The terminal numbering is now consistent with the connections of the transformers.