Skip to content

Conversation

@ccoffrin
Copy link
Member

@ccoffrin ccoffrin commented Apr 1, 2022

Closes #820, #821

@jay-dave heads up this may break some of your code but will be in the next non-breaking release as this a bug fix.

@matteorossini thanks for all the help finding these bugs in the the solution building tools!

@codecov
Copy link

codecov bot commented Apr 1, 2022

Codecov Report

Merging #822 (c959691) into master (c9544b5) will decrease coverage by 0.01%.
The diff coverage is 89.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #822      +/-   ##
==========================================
- Coverage   93.88%   93.86%   -0.02%     
==========================================
  Files          42       42              
  Lines        9873     9877       +4     
==========================================
+ Hits         9269     9271       +2     
- Misses        604      606       +2     
Impacted Files Coverage Δ
src/form/wr.jl 99.12% <33.33%> (-0.44%) ⬇️
src/core/solution.jl 83.33% <100.00%> (+2.08%) ⬆️
src/form/apo.jl 88.48% <100.00%> (ø)
src/form/dcp.jl 97.18% <100.00%> (ø)
src/form/lpac.jl 96.68% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9544b5...c959691. Read the comment docs.

@ccoffrin ccoffrin merged commit 8c7c710 into master Apr 1, 2022
@ccoffrin ccoffrin deleted the sol-ne-bug branch April 1, 2022 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistent solution keys across variable_ne_branch_* methods

2 participants