-
Notifications
You must be signed in to change notification settings - Fork 164
Export HVDC to PSSE (fix: #754) #791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #791 +/- ##
==========================================
+ Coverage 93.98% 94.00% +0.02%
==========================================
Files 42 42
Lines 9757 9794 +37
==========================================
+ Hits 9170 9207 +37
Misses 587 587
Continue to review full report at Codecov.
|
|
I did a quick skim and this is how I would approach it as well. If the user does Note
|
|
I agree with you to add this types of tests. In the next days I will try to produce a useful output without the |
|
@ccoffrin, I would like to know what you think about the power flows that I ran for
The results are in the following tables:
Let me know what things would be necessary (more tests or another side by side comparision) to perform the merge. |
|
@jbarberia, this is a good observation! When implementing this model I strived to match Matpower's specification, but I did not to a lot of testing, so possibly I got a detail incorrect here or there. I usually only test OPF as well and not PF when porting a feature from another solver. I am surly open to considering changes in the PF specification for DC lines to make them more consistent with Matpower. I would suspect there a variation in how the bus type semantics are handled (i.e., should HVDC buses be PQ or PV? I set them up as PV based on the bus vm value and it looks like Matpower is doing something different maybe following the generator's vm target?). I suspect, if to load the case into PowerModels and then re-export it to Matpower you will find the results to be more consistent as PowerModels' data cleaning will be reflected in the new Matpower file. It would also be convenient if the results were also consistent with PSSE. However, this may not be possible as there may be no encoding of Matpower's semantics into PSSE (DC line losses are one point that comes to mind). So we may have to accept some deviations in this case. I am open to merging this as-is, as I find these convention deviations acceptable. However, would you prefer to make changes to that the models are more consistent? |
|
I just did a code review with the hope of merging soon. Looks reasonable to me. I did wonder if we need both |
|
@ccoffrin, I used the But now it is totally unnecessary, so I will delete it. |
What do you think of having a support to export HVDC lines in this way?
I compare side by side the results in PSSE doing this process:
original_raw -> parse_file -> export_file -> new_rawand its works pretty decent.The only drawback is that it would work correctly if
import_all = truein theparse_file function.For the moment I did not check if it could export to PSSE a file coming from MATPOWER.