ext_redis.py support redis clusters --- Fixes #9538 #9789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: root <root@localhost.localdomain>
dosubot
bot
added
the
size:S
Signed-off-by: root <root@localhost.localdomain>
dosubot
bot
added
size:M
Signed-off-by: root <root@localhost.localdomain>
|
LGTM overall. cc @takatost @laipz8200 |
Okay Co-authored-by: Bowen Liang <bowenliang@apache.org>
Signed-off-by: root <root@localhost.localdomain>
|
@bowenliang123 @takatost @laipz8200 Can the code be merged into the main branch? Please confirm, thanks. |
|
Please make sure the CI passes. |
|
There can not see CI is running, only display "2 workflows awaiting approval" , Why? @laipz8200 @bowenliang123 |
|
Because this is your first ever PR in this repo, all workflows are executed only when the maintainer approves the runs. You may need a hand from @laipz8200 @crazywoola . Or you may test it locally and raise your screenshot evidence for passing the tests. |
added 3 commits
November 11, 2024 18:23
Signed-off-by: root <root@localhost.localdomain>
Signed-off-by: root <root@localhost.localdomain>
Signed-off-by: root <root@localhost.localdomain>
|
CI has passed, looking forward to merging into main, thanks. @laipz8200 |
|
Please also add the new environment variables to |
Signed-off-by: root <root@localhost.localdomain>
laipz8200
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Important
Please review the checklist below before submitting your pull request.
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint godsDescription
This submission has enabled support for starting Redis clusters in the ext_redis.py
Fixes #9538
Type of Change
Testing Instructions
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration