Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix editor auth #7297

Merged
merged 1 commit into from
Aug 15, 2024
Merged

fix editor auth #7297

merged 1 commit into from
Aug 15, 2024

Conversation

cuckootan
Copy link
Contributor

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

A complementary fix for issue #6519

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • editors can view conversation subpage
image

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🐞 bug Something isn't working labels Aug 15, 2024
@crazywoola
Copy link
Member

Please fix the tests accordiingly.

@cuckootan cuckootan closed this Aug 15, 2024
@cuckootan cuckootan reopened this Aug 15, 2024
@cuckootan
Copy link
Contributor Author

Please fix the tests accordiingly.

There is something wrong in other place instead of my change. I reopen pr and all tests are passed.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 15, 2024
@crazywoola crazywoola merged commit acfab01 into langgenius:main Aug 15, 2024
9 of 12 checks passed
cuiks pushed a commit to cuiks/dify that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants