Skip to content

Commit 0c2e024

Browse files
committed
fixed failing ITs
1 parent a43917b commit 0c2e024

File tree

2 files changed

+14
-14
lines changed

2 files changed

+14
-14
lines changed

langchain4j-google-ai-gemini/src/test/java/dev/langchain4j/model/googleai/GoogleAiGeminiChatModelIT.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ void should_support_video_file() {
167167
assertThat(response.aiMessage().text()).containsIgnoringCase("example");
168168
}
169169

170-
@Test
170+
@RetryingTest(3)
171171
void should_execute_python_code() {
172172
// given
173173
GoogleAiGeminiChatModel gemini = GoogleAiGeminiChatModel.builder()
@@ -220,21 +220,21 @@ void should_support_JSON_array_in_tools() {
220220
// then
221221
assertThat(response.aiMessage().hasToolExecutionRequests()).isTrue();
222222
assertThat(response.aiMessage().toolExecutionRequests().get(0).name()).isEqualTo("getFirstNFibonacciNumbers");
223-
assertThat(response.aiMessage().toolExecutionRequests().get(0).arguments())
224-
.contains("\"n\":10");
223+
assertThat(response.aiMessage().toolExecutionRequests().get(0).arguments()).contains("\"n\":10");
225224

226225
allMessages.add(response.aiMessage());
227226

228227
// when
229-
ToolExecutionResultMessage forecastResult =
230-
ToolExecutionResultMessage.from(null, "getFirstNFibonacciNumbers", "[0, 1, 1, 2, 3, 5, 8, 13, 21, 34]");
231-
allMessages.add(forecastResult);
228+
String fibonacciNumbers = "[0, 1, 1, 2, 3, 5, 8, 13, 21, 34]";
229+
ToolExecutionResultMessage toolResult =
230+
ToolExecutionResultMessage.from(null, "getFirstNFibonacciNumbers", fibonacciNumbers);
231+
allMessages.add(toolResult);
232232

233233
// then
234234
response = gemini.chat(allMessages);
235235

236236
// then
237-
assertThat(response.aiMessage().text()).contains("[0, 1, 1, 2, 3, 5, 8, 13, 21, 34]");
237+
assertThat(response.aiMessage().text()).containsIgnoringWhitespaces(fibonacciNumbers);
238238
}
239239

240240
@Disabled("TODO fix")

langchain4j-google-ai-gemini/src/test/java/dev/langchain4j/model/googleai/GoogleAiGeminiStreamingChatModelIT.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ void should_support_video_file() {
142142
// ToDo waiting for the normal GoogleAiGeminiChatModel to implement the test
143143
}
144144

145-
@Test
145+
@RetryingTest(3)
146146
void should_execute_python_code() {
147147
// given
148148
GoogleAiGeminiStreamingChatModel gemini = GoogleAiGeminiStreamingChatModel.builder()
@@ -200,23 +200,23 @@ void should_support_JSON_array_in_tools() {
200200
// then
201201
assertThat(response1.aiMessage().hasToolExecutionRequests()).isTrue();
202202
assertThat(response1.aiMessage().toolExecutionRequests().get(0).name()).isEqualTo("getFirstNFibonacciNumbers");
203-
assertThat(response1.aiMessage().toolExecutionRequests().get(0).arguments())
204-
.contains("\"n\":10");
203+
assertThat(response1.aiMessage().toolExecutionRequests().get(0).arguments()).contains("\"n\":10");
205204

206205
allMessages.add(response1.aiMessage());
207206

208207
// when
209-
ToolExecutionResultMessage forecastResult =
210-
ToolExecutionResultMessage.from(null, "getFirstNFibonacciNumbers", "[0, 1, 1, 2, 3, 5, 8, 13, 21, 34]");
211-
allMessages.add(forecastResult);
208+
String fibonacciNumbers = "[0, 1, 1, 2, 3, 5, 8, 13, 21, 34]";
209+
ToolExecutionResultMessage toolResult =
210+
ToolExecutionResultMessage.from(null, "getFirstNFibonacciNumbers", fibonacciNumbers);
211+
allMessages.add(toolResult);
212212

213213
// then
214214
TestStreamingChatResponseHandler handler2 = new TestStreamingChatResponseHandler();
215215
gemini.chat(allMessages, handler2);
216216
ChatResponse response2 = handler2.get();
217217

218218
// then
219-
assertThat(response2.aiMessage().text()).contains("[0, 1, 1, 2, 3, 5, 8, 13, 21, 34]");
219+
assertThat(response2.aiMessage().text()).containsIgnoringWhitespaces(fibonacciNumbers);
220220
}
221221

222222
@RetryingTest(5)

0 commit comments

Comments
 (0)