Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue: evaluate is very slow (because get_git_info) #1074

Open
davidgilbertson opened this issue Oct 7, 2024 · 1 comment
Open

Issue: evaluate is very slow (because get_git_info) #1074

davidgilbertson opened this issue Oct 7, 2024 · 1 comment

Comments

@davidgilbertson
Copy link

Issue you'd like to raise.

I've noticed that evaluate is taking over a minute and a half to run on a single example. I eventually tracked it down to the fact that LangSmith is calling some git commands in the background and this takes about 1m:28s (the actual evals take about 2 seconds).

Suggestion:

Is this really necessary? I should be able to run evals without involving git, no? Even if I'm an outlier with my very slow git repo, it still seems like overhead that could be avoided.

I don't want all that git info as my metadata anyway, I would like a way to opt out (or in).

If you're wondering why my git is so slow, it's because I'm using WSL2 + with files on Windows which is known to be slow with git. It's perfectly fine most of the time, but things like git status take a while. This is the first time I've come across a Python package that called git, so had never really noticed the problem until now.

@hinthornw
Copy link
Collaborator

Fun! Thanks for flagging! Agreed with the feedback - will make some changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants