Skip to content

Upgrade zod dependency #8388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

brichet
Copy link
Contributor

@brichet brichet commented Jun 18, 2025

The current version of zod (3.25.51) has an issue when building with "skipLibCheck": false is specified in tsconfig.json.

See colinhacks/zod#4545 and colinhacks/zod#4624 for more constext.

This PR fix it by upgrading the version of zod.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jun 18, 2025
Copy link

vercel bot commented Jun 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-docs ✅ Ready (Inspect) Visit Preview Jun 18, 2025 0:43am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ⬜️ Ignored (Inspect) Jun 18, 2025 0:43am

@brichet brichet mentioned this pull request Jun 18, 2025
@dosubot dosubot bot added the auto:bug Related to a bug, vulnerability, unexpected error with an existing feature label Jun 18, 2025
Copy link
Contributor

@hntrl hntrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity does your package manager not automatically resolve to the same zod deps for langchain if you set the minimum requirement? I.e. if you set zod to be "^3.25.56" in your package.json does that fix your lib check errors? (I would assume it would?)

This resolutions key you're updating here won't actually impact the deps that released packages call for, it's just yarn's way of globally pinning a package version for local dev. If upgrading the dep in your package.json doesn't work we need to update the zod deps directly in each dependencies field of each package.json instead of just setting the resolutions

@brichet
Copy link
Contributor Author

brichet commented Jun 19, 2025

Right, this change would not impact our dependencies.
I just saw that the culprit was a pinned version in @langchain/openai, which has already been addressed in #8380.
Sorry for the noise 😄

@brichet brichet closed this Jun 19, 2025
@brichet brichet deleted the upgrade_zod branch June 27, 2025 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:bug Related to a bug, vulnerability, unexpected error with an existing feature size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants