Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core[patch]: fix: Document should handle empty pageContent (fixes #5884) #5885

Merged
merged 3 commits into from
Jun 25, 2024
Merged

core[patch]: fix: Document should handle empty pageContent (fixes #5884) #5885

merged 3 commits into from
Jun 25, 2024

Conversation

glorat
Copy link
Contributor

@glorat glorat commented Jun 25, 2024

Fixes #5884

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jun 25, 2024
@vercel Vercel
Copy link

vercel bot commented Jun 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2024 5:31pm
langchainjs-docs ✅ Ready (Inspect) Visit Preview Jun 25, 2024 5:31pm

@dosubot dosubot bot added the auto:bug Related to a bug, vulnerability, unexpected error with an existing feature label Jun 25, 2024
@jacoblee93
Copy link
Collaborator

jacoblee93 commented Jun 25, 2024 •
edited
Loading

This technically breaks the interface - why do we need to check for this?

Well, I guess technically it was already needlessly defensive. I suppose this is fine.

@jacoblee93 jacoblee93 changed the title fix: Document should handle empty pageContent (fixes #5884) core[patch]: fix: Document should handle empty pageContent (fixes #5884) Jun 25, 2024
@jacoblee93
Copy link
Collaborator

Thank you! Generally against this kind of defensive check but since it's already there might as well fix it.

@jacoblee93 jacoblee93 added the lgtm PRs that are ready to be merged as-is label Jun 25, 2024
@jacoblee93 jacoblee93 merged commit 5b73067 into langchain-ai:main Jun 25, 2024
37 checks passed
@glorat glorat deleted the fix-5884 branch June 28, 2024 06:16
@abdulrahman305 abdulrahman305 mentioned this pull request Jul 4, 2024
Merged
This was referenced Jul 17, 2024
Open
Open
@Skrishnan586 Skrishnan586 mentioned this pull request Jul 22, 2024
Open
@prathik2401 prathik2401 mentioned this pull request Jul 24, 2024
Merged
@abdulrahman305 abdulrahman305 mentioned this pull request Jul 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
auto:bug Related to a bug, vulnerability, unexpected error with an existing feature lgtm PRs that are ready to be merged as-is size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document.pageContent should not allow undefined
2 participants
@glorat @jacoblee93