Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community-experimental[minor]: feat: implement DatadogLLMObsTracer #5867

Merged
merged 11 commits into from
Jun 25, 2024

Conversation

josemussa
Copy link
Contributor

This is an implementation of Datadog's LLM Observability API as a LangChain Tracer.

It provides support for the following Datadog spans: "llm", "tool", "workflow", "retrieval".

@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Jun 22, 2024
Copy link

vercel bot commented Jun 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2024 4:41pm
langchainjs-docs ✅ Ready (Inspect) Visit Preview Jun 25, 2024 4:41pm

@dosubot dosubot bot added the auto:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features label Jun 22, 2024
@@ -0,0 +1,374 @@
import { BaseCallbackHandlerInput } from "@langchain/core/callbacks/base";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! I've reviewed the code and noticed that the new DatadogLLMObsTracer class includes a method persistRun that makes a new external HTTP request using the fetch API. I've flagged this change for your review to ensure it aligns with the project's requirements and best practices. Let me know if you have any questions or need further clarification!

@@ -0,0 +1,374 @@
import { BaseCallbackHandlerInput } from "@langchain/core/callbacks/base";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! I've reviewed the code changes, and it looks like the diff adds and accesses environment variables using the getEnvironmentVariable function. I've flagged this for your review to ensure it aligns with the intended functionality. Let me know if you need further assistance!

@@ -0,0 +1,383 @@
import { test, jest, expect } from "@jest/globals";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey team, just a heads up that this PR introduces new HTTP requests using the fetch function. I've flagged this for your review to ensure it aligns with our project's requirements and best practices. Let me know if you need any further assistance with this.

@jacoblee93 jacoblee93 changed the title feat: implement DatadogLLMObsTracer community-experimental[minor]: feat: implement DatadogLLMObsTracer Jun 25, 2024
@jacoblee93 jacoblee93 added the lgtm PRs that are ready to be merged as-is label Jun 25, 2024
@jacoblee93
Copy link
Collaborator

Moved to experimental since API is still in beta, but looks great thanks!

@biswarup-banerjee
Copy link

Thanks again for this!
Really cool and helful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features lgtm PRs that are ready to be merged as-is size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants