Allow clearing cache and fix gptcache #3493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwchase17
reviewed
Apr 25, 2023
hwchase17
reviewed
Apr 25, 2023
| @@ -235,4 +235,5 @@ def save_context(self, inputs: Dict[str, Any], outputs: Dict[str, str]) -> None: | |||
| def clear(self) -> None: | |||
| """Clear memory contents.""" | |||
| self.chat_memory.clear() | |||
| self.entity_cache.clear() | |||
There was a problem hiding this comment.
entity_cache is a List[str] right? this shouldnt work?
There was a problem hiding this comment.
Am I misunderstanding anything? clear is a valid method on list in python.
There was a problem hiding this comment.
mind blown i didnt actually know that
vowelparrot
pushed a commit
that referenced
this pull request
Apr 28, 2023
This PR * Adds `clear` method for `BaseCache` and implements it for various caches * Adds the default `init_func=None` and fixes gptcache integtest * Since right now integtest is not running in CI, I've verified the changes by running `docs/modules/models/llms/examples/llm_caching.ipynb` (until proper e2e integtest is done in CI)
samching
pushed a commit
to samching/langchain
that referenced
this pull request
May 1, 2023
This PR * Adds `clear` method for `BaseCache` and implements it for various caches * Adds the default `init_func=None` and fixes gptcache integtest * Since right now integtest is not running in CI, I've verified the changes by running `docs/modules/models/llms/examples/llm_caching.ipynb` (until proper e2e integtest is done in CI)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
clearmethod forBaseCacheand implements it for various cachesinit_func=Noneand fixes gptcache integtestdocs/modules/models/llms/examples/llm_caching.ipynb(until proper e2e integtest is done in CI)