Remove pythonrepl from LLM-MathChain #2943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use numexpr evaluate instead of the python repl. Tested against the (limited) math dataset and got the same score as before.
vowelparrot
force-pushed
the
vwp/use_numexpr_math_chain
branch
from
a2c5c65
to
2af60b0
Compare
vowelparrot
force-pushed
the
vwp/use_numexpr_math_chain
branch
from
4c9dc2f
to
a24a541
Compare
vowelparrot
changed the title
samching
pushed a commit
to samching/langchain
that referenced
this pull request
May 1, 2023
Use numexpr evaluate instead of the python REPL to avoid malicious code injection. Tested against the (limited) math dataset and got the same score as before. For more permissive tools (like the REPL tool itself), other approaches ought to be provided (some combination of Sanitizer + Restricted python + unprivileged-docker + ...), but for a calculator tool, only mathematical expressions should be permitted. See langchain-ai#814
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use numexpr evaluate instead of the python REPL to avoid malicious code injection.
Tested against the (limited) math dataset and got the same score as before.
For more permissive tools (like the REPL tool itself), other approaches ought to be provided (some combination of Sanitizer + Restricted python + unprivileged-docker + ...), but for a calculator tool, only mathematical expressions should be permitted.
See #814