Don't use dynamic api endpoint for Zapier NLA #1803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralewis85
reviewed
Mar 20, 2023
langchain/tools/zapier/tool.py
Outdated
| @@ -1,6 +1,6 @@ | |||
| """## Zapier Natural Language Actions API | |||
| \ | |||
| Full docs here: https://nla.zapier.com/api/v1/dynamic/docs | |||
| Full docs here: https://nla.zapier.com/api/v1/docs | |||
There was a problem hiding this comment.
This and the other changes for docs should remain https://nla.zapier.com/api/v1/dynamic/docs.
It's a bit of an inconsistency on our end when it comes to expressing which route to use. The only change needed in the MR should be to zapier_nla_api_dynamic_base like you've done.
|
LGTM! |
bryanhelmig
added a commit
to bryanhelmig/langchain
that referenced
this pull request
Mar 20, 2023
hwchase17
pushed a commit
that referenced
this pull request
Mar 20, 2023
The base docs are going to be more stable and familiar for folks. Dynamic route is currently in flux.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From Robert "Right now the dynamic/ route for specifically the above endpoints is acting on all providers a user has set up, not just the provider for the supplied API key."