Harrison/summary message rol #1783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion memory (#1750) In the current `ConcersationSummaryMemory`, `ConversationSummaryBufferMemory` and `ConversationKGMemory`, summarized messages are stored as `SystemMessage`. However, according to the official documentation, gpt-3.5-turbo does not pay much attention to the `system` role message and prefers important information to be provided in the `user` role. Quote 1 (https://github.com/openai/openai-python/blob/main/chatml.md) > If adding instructions in the `system` message doesn't work, you can also try putting them into a `user` message. (In the near future, we will train our models to be much more steerable via the system message. But to date, we have trained only on a few system messages, so the models pay much more attention to user examples.) Quote 2 (https://github.com/openai/openai-cookbook/blob/main/examples/How_to_format_inputs_to_ChatGPT_models.ipynb) > The system message can be used to prime the assistant with different personalities or behaviors. > > However, the model does not generally pay as much attention to the system message, and therefore we recommend placing important instructions in the user message instead. Therefore, this PR changes the behavior to allow storing summary messages in roles other than system. A new variable `summary_message_role` is added with a default value of `"system"`. Depending on the value of this variable, the summary will be stored as a `HumanMessage`, `AIMessage`, or `SystemMessage`.
hwchase17
pushed a commit
that referenced
this pull request
Mar 19, 2023
After the changes in #1783, `summary_message_role` is no longer used in `ConversationSummaryBufferMemory`, so this PR removes it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.