Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use separate jobs for building and publishing test releases. #12671

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

obi1kenobi
Copy link
Collaborator

@obi1kenobi obi1kenobi commented Oct 31, 2023

This follows the principle of least privilege. Our poetry build step doesn't need, and shouldn't get, access to our GitHub OIDC capability.

This is the same structure as I used in the already-merged PR for refactoring the regular PyPI release workflow: #12578.

This follows the principle of least privilege. Our `poetry build` step doesn't need, and shouldn't get, access to our GitHub OIDC capability.
Copy link

vercel bot commented Oct 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Oct 31, 2023 8:20pm

@dosubot dosubot bot added the 🤖:improvement Medium size change to existing code to handle new use-cases label Oct 31, 2023
@obi1kenobi obi1kenobi merged commit 321cd44 into master Nov 1, 2023
@obi1kenobi obi1kenobi deleted the pg/separate_build_from_publish_in_test_release branch November 1, 2023 01:36
xieqihui pushed a commit to xieqihui/langchain that referenced this pull request Nov 21, 2023
…in-ai#12671)

This follows the principle of least privilege. Our `poetry build` step
doesn't need, and shouldn't get, access to our GitHub OIDC capability.

This is the same structure as I used in the already-merged PR for
refactoring the regular PyPI release workflow: langchain-ai#12578.
hoanq1811 pushed a commit to hoanq1811/langchain that referenced this pull request Feb 2, 2024
…in-ai#12671)

This follows the principle of least privilege. Our `poetry build` step
doesn't need, and shouldn't get, access to our GitHub OIDC capability.

This is the same structure as I used in the already-merged PR for
refactoring the regular PyPI release workflow: langchain-ai#12578.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:improvement Medium size change to existing code to handle new use-cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants