Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure all integration doc pages show packages to install and import correctly #22005

Closed
1 task done
baskaryan opened this issue May 22, 2024 · 0 comments
Closed
1 task done
Labels
🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Good issue for contributors

Comments

@baskaryan
Copy link
Collaborator

baskaryan commented May 22, 2024

Privileged issue

  • I am a LangChain maintainer, or was asked directly by a LangChain maintainer to create an issue here.

Issue Content

Make sure all integration docs:

  1. explicitly list/install the langchain package(s) needed to use the integration
    a. e.g. "You'll need to install langchain-community with pip install -qU langchain-community to use this integration"
  2. import the integration from the correct package
    a. eg there should be no more imports of the form from langchain.vectorstores import ... they should all be from langchain_community.vectorstores import ..., from langchain_pinecone.vectorstores import ..., etc
@baskaryan baskaryan added documentation Improvements or additions to documentation help wanted Good issue for contributors good first issue Good for newcomers labels May 22, 2024
@dosubot dosubot bot added the 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder label May 22, 2024
maximeperrindev pushed a commit to maximeperrindev/langchain that referenced this issue May 22, 2024
eyurtsev pushed a commit that referenced this issue May 22, 2024
…22028)

- **Description:** Adding installation instruction for integrations
requiring `langchain-community` package since 0.2
  - **Issue:** #22005

---------

Co-authored-by: Maxime Perrin <mperrin@doing.fr>
maximeperrindev pushed a commit to maximeperrindev/langchain that referenced this issue May 23, 2024
eyurtsev pushed a commit that referenced this issue May 23, 2024
- **Description:** Adding correct imports to the integrations callbacks
doc (langchain-community package)
  - **Issue:** #22005

---------

Co-authored-by: Maxime Perrin <mperrin@doing.fr>
eyurtsev pushed a commit that referenced this issue May 23, 2024
- **PR title**:  Docs enhancement

- **Description:** Adding installation instructions for integrations
requiring `langchain-community` package since 0.2
    - **Issue:** #22005
baskaryan pushed a commit that referenced this issue May 27, 2024
PR title: Docs enhancement

Description: Adding installation instructions for integrations requiring
langchain-community package since 0.2
Issue: #22005
ccurme pushed a commit that referenced this issue May 29, 2024
PR title: Integration Docs enhancement

Description: Adding installation instructions for integrations requiring
langchain-community package since 0.2
Issue: [#22005](#22005)
efriis pushed a commit that referenced this issue Jun 11, 2024
…22392)

**Title:** Updated integration docs with required package installations
   **Issue:**  #22005
hinthornw pushed a commit that referenced this issue Jun 20, 2024
…22028)

- **Description:** Adding installation instruction for integrations
requiring `langchain-community` package since 0.2
  - **Issue:** #22005

---------

Co-authored-by: Maxime Perrin <mperrin@doing.fr>
hinthornw pushed a commit that referenced this issue Jun 20, 2024
- **Description:** Adding correct imports to the integrations callbacks
doc (langchain-community package)
  - **Issue:** #22005

---------

Co-authored-by: Maxime Perrin <mperrin@doing.fr>
hinthornw pushed a commit that referenced this issue Jun 20, 2024
- **PR title**:  Docs enhancement

- **Description:** Adding installation instructions for integrations
requiring `langchain-community` package since 0.2
    - **Issue:** #22005
hinthornw pushed a commit that referenced this issue Jun 20, 2024
PR title: Docs enhancement

Description: Adding installation instructions for integrations requiring
langchain-community package since 0.2
Issue: #22005
hinthornw pushed a commit that referenced this issue Jun 20, 2024
PR title: Integration Docs enhancement

Description: Adding installation instructions for integrations requiring
langchain-community package since 0.2
Issue: [#22005](#22005)
hinthornw pushed a commit that referenced this issue Jun 20, 2024
…22392)

**Title:** Updated integration docs with required package installations
   **Issue:**  #22005
ccurme added a commit that referenced this issue Jul 2, 2024
PR title: Docs enhancement

- Description: Adding installation instructions for integrations
requiring langchain-community package since 0.2
- Issue: #22005

---------

Co-authored-by: ccurme <chester.curme@gmail.com>
@efriis efriis mentioned this issue Jul 30, 2024
2 tasks
@dosubot dosubot bot added the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Aug 21, 2024
@dosubot dosubot bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 28, 2024
@dosubot dosubot bot removed the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Good issue for contributors
Projects
None yet
Development

No branches or pull requests

1 participant