Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RecordManager Bigquery #549

Open
Freezaa9 opened this issue Oct 10, 2024 · 2 comments
Open

RecordManager Bigquery #549

Freezaa9 opened this issue Oct 10, 2024 · 2 comments

Comments

@Freezaa9
Copy link
Contributor

Hello,

We work in a full GCP environment with Vertex Search (matching engine as Vector DB).
And one of the drawback of this solution is the need to keep a side index of what is currently in the DB and the complexity to manage update and deletion without creating duplicate documents.

I feel that implementing RecordManager for Bigquery would solve all this problem and allow to easily track what's in the vector db:
https://python.langchain.com/docs/how_to/indexing/
https://api.python.langchain.com/en/latest/indexes/langchain.indexes.base.RecordManager.html

The langchain documentation say:

Only works with LangChain vectorstore's that support:
document addition by id (add_documents method with ids argument)
delete by id (delete method with ids argument)

So it is the case for Vertex Search (in streaming mode).

There is no RecordManager yet in GCP. A PR for firestore is ongoing (googleapis/langchain-google-firestore-python#90) but I feel like BigQuery might be more suitable for this use case.

Happy to discuss the implementation and suitability :)

@Freezaa9
Copy link
Contributor Author

Freezaa9 commented Oct 10, 2024

I just noticed that "delete" is not implemented in VectorSearchVectorStore
https://github.com/langchain-ai/langchain-google/pull/331/files

@lkuligin
Copy link
Collaborator

@eliasecchig

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants