Skip to content

Conversation

@eyurtsev
Copy link
Collaborator

@eyurtsev eyurtsev commented Dec 12, 2023

  • This PR adds code for running custom agents to the langchain benchmarking repo.
  • The agent code is good enough for experimentation / prototyping, but I don't think it's good enough for the langchain repo:
    -- The abstractions aren't fully implemented and aren't ready for production use -- but OK for research
    -- For production use, one may want to remove all the intermediate abstractions to keep the agent as simple as possible

I was thinking initially of including this in a different repo, but I think it's over-complicating things, probably OK to include some reference implementations inside of langchain benchmarks.

@eyurtsev
Copy link
Collaborator Author

Continuing work from here: #109

But some changes have been merged (e.g., model registry) and benchmarking code etc

@eyurtsev eyurtsev changed the title Agents 2: Draft Adds custom agents to the langchain benchmarking repo Dec 14, 2023
@eyurtsev eyurtsev marked this pull request as ready for review December 14, 2023 15:46
@eyurtsev eyurtsev requested a review from hinthornw December 14, 2023 15:48
@eyurtsev eyurtsev merged commit 8798735 into main Dec 14, 2023
@eyurtsev eyurtsev deleted the eugene/agents_2 branch December 14, 2023 17:06
@hinthornw
Copy link
Collaborator

Heh got caught mid review but looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants