-
-
Notifications
You must be signed in to change notification settings - Fork 64
Expose metrics from NGINX and Bind to Prometheus #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Exposing zone statistic for Bind9 in web interface. https://kb.isc.org/docs/monitoring-recommendations-for-bind-9 Co-authored-by: William Bergmann Børresen <ninkaninus@users.noreply.github.com>
Co-authored-by: William Bergmann Børresen <ninkaninus@users.noreply.github.com>
Co-authored-by: William Bergmann Børresen <ninkaninus@users.noreply.github.com>
Co-authored-by: William Bergmann Børresen <ninkaninus@users.noreply.github.com>
This also adds labels for the ease of filtering in Prometheus/Grafana Co-authored-by: William Bergmann Børresen <ninkaninus@users.noreply.github.com>
Co-authored-by: William Bergmann Børresen <ninkaninus@users.noreply.github.com>
This issue has been automatically marked as inactive because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This is still awating review. When looking at the issue, there seems to be an interest in getting these features. If not all, then some. |
This issue has been automatically marked as inactive because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This is still awating review. |
I think this is a nice addition, but I'm torn as to whether it should be included by default. My gut feeling would be to include the env var in the .env file, but provide a "docker-compose.yml.prometheus" that can be used if you want to run with the Prometheus backend. We can update the Readme.md to include instructions to run with the Prometheus backend. Thoughts @lancachenet/core ? |
Having an alternative docker compose file, would definitely allow for flexibility, while preserving ease of use for current users. The update does not really need the .env update (or it is so small, it won't impact the "simple" version). Making a seperate for that would probably be overkill. Looking at the docker-compose.yml file now, I can see that multiple elements have changed in the Docker compose ecosystem since it was written. |
…e and the seperation into two docker compose files
I have updated the PR with the metrics exports being split into a seperate file called Just to note, the lancachenet/lancache-dns#140 PR needs to be merged, before the metrics docker compose file will work correctly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also LGTM, based on the lancache-dns changes being merged.
FYI, we have an event next week so we will likely test it off there before fully committing the PR. |
If anything seems unclear, when setting up the system, then you are more than welcome to reach out, so that we can get that fixed and documented. |
This update is the docker-compose update for the NGINX and Bind export to Prometheus.
Please see #38 for further information about this update as this solves #38
In short, we have added two exporters, to export status from Bind and NGINX, such that Prometheus can scrape the data.
This update also includes network segregation, such that the exporters only have access to the services they need, and no more.
And we have updated the README.md, to include a short description of how to use the metrics.