-
Notifications
You must be signed in to change notification settings - Fork 3
More formatting and LAMMPS-GUI revisions #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@simongravelle FYI, LAMMPS and LAMMPS-GUI now use a mutex to avoid reading and updating of thermodynamic data at the same time. This should get rid of (most?) of the unexpected outliers in the charts due to data corruption. We also should set a deadline, say a week (?) before the planned submission, for when we stop making content changes and work on the final checks for consistency and layout that I added to the TODO list. |
I would be happy to do set a deadline, yes. Initially, the article was supposed to be submitted in January, but I don't know if you think it's possible, considering your other constraints? If you think that its possible, I would be glad to dedicate the last week (for instance) of January to the last checks. If not, I am sure that we can delay a bit the submission, there is no need to rush it. On the side note, I would have loved to have a DOI by January 31th for a report I have to write on a finishing grant, but I can also just export a "beta version" of the repository to Zenodo, and tell them its "a submitted paper". On my side, I have made all the revisions I intended to the tutorials. My current state it that I am waiting for eventual comments/critics that you (and @jrgissing as well) may have on the tutorials that would require some change. |
I cannot say at the moment. Some changes have taken more time than expected and I currently need to balance between working on this article, LAMMPS itself, and Temple HPC. On the LAMMPS side, I am trying to finish some long-standing pending changes and reduce the number of pending pull requests to make a new feature release soon. Currently, thanks to some extra effort over the weekend, all but one of these PRs that require me working on them are ready to merge. Part of them also required some difficult (for me) changes to the LAMMPS testing environment we operate at Temple, so that took a lot of time debugging and fixing. Due to Christmas break, progress was slow on reviewing and improving pending pull requests but it is picking up speed now. There are two important meetings today and tomorrow and then I should have a better picture. I am comfortable with the intro, tutorials 1 and 2, and the appendices. I have only looked at the rest superficially, so that will need to have a closer look. I am eager to give this priority and have it done. I am very happy with how things turned out so far. Let's do another assessment a week from today. |
Perfect |
Hi @akohlmey, hi @jrgissing, if you have no objection, I will create a "beta" release of the current state of the repository, and upload it to Zenodo. |
You should merge this pull request first. |
This continues the revision of the article and updating or correcting references to LAMMPS-GUI use.