Skip to content

Conversation

@akohlmey
Copy link
Collaborator

This continues the revision of the article and updating or correcting references to LAMMPS-GUI use.

@akohlmey
Copy link
Collaborator Author

@simongravelle FYI, LAMMPS and LAMMPS-GUI now use a mutex to avoid reading and updating of thermodynamic data at the same time. This should get rid of (most?) of the unexpected outliers in the charts due to data corruption.
I am also improving the WHAM code to not create any NaN or Inf output.
Finally, I am working on a "Run WHAM Utility" dialog for LAMMPS-GUI that will allow to enter the command line parameters. I will also look into having it pre-filled with some data, e.g. from scanning through the current input file (units) and by remembering which values were used the last time.
Once this is completed, I will produce new binaries.

We also should set a deadline, say a week (?) before the planned submission, for when we stop making content changes and work on the final checks for consistency and layout that I added to the TODO list.
Please let me know what you think.

@simongravelle
Copy link
Member

We also should set a deadline, say a week (?) before the planned submission, for when we stop making content changes and work on the final checks for consistency and layout that I added to the TODO list.

I would be happy to do set a deadline, yes. Initially, the article was supposed to be submitted in January, but I don't know if you think it's possible, considering your other constraints? If you think that its possible, I would be glad to dedicate the last week (for instance) of January to the last checks. If not, I am sure that we can delay a bit the submission, there is no need to rush it. On the side note, I would have loved to have a DOI by January 31th for a report I have to write on a finishing grant, but I can also just export a "beta version" of the repository to Zenodo, and tell them its "a submitted paper".

On my side, I have made all the revisions I intended to the tutorials. My current state it that I am waiting for eventual comments/critics that you (and @jrgissing as well) may have on the tutorials that would require some change.

@akohlmey
Copy link
Collaborator Author

I would be happy to do set a deadline, yes. Initially, the article was supposed to be submitted in January, but I don't know if you think it's possible, considering your other constraints?

I cannot say at the moment. Some changes have taken more time than expected and I currently need to balance between working on this article, LAMMPS itself, and Temple HPC. On the LAMMPS side, I am trying to finish some long-standing pending changes and reduce the number of pending pull requests to make a new feature release soon. Currently, thanks to some extra effort over the weekend, all but one of these PRs that require me working on them are ready to merge. Part of them also required some difficult (for me) changes to the LAMMPS testing environment we operate at Temple, so that took a lot of time debugging and fixing. Due to Christmas break, progress was slow on reviewing and improving pending pull requests but it is picking up speed now. There are two important meetings today and tomorrow and then I should have a better picture. I am comfortable with the intro, tutorials 1 and 2, and the appendices. I have only looked at the rest superficially, so that will need to have a closer look. I am eager to give this priority and have it done. I am very happy with how things turned out so far.

Let's do another assessment a week from today.

@simongravelle
Copy link
Member

Let's do another assessment a week from today.

Perfect

@simongravelle
Copy link
Member

I would have loved to have a DOI by January 31th for a report I have to write on a finishing grant, but I can also just export a "beta version" of the repository to Zenodo, and tell them its "a submitted paper".

Hi @akohlmey, hi @jrgissing, if you have no objection, I will create a "beta" release of the current state of the repository, and upload it to Zenodo.

@akohlmey
Copy link
Collaborator Author

Hi @akohlmey, hi @jrgissing, if you have no objection, I will create a "beta" release of the current state of the repository, and upload it to Zenodo.

You should merge this pull request first.

@akohlmey akohlmey marked this pull request as ready for review January 27, 2025 09:00
@simongravelle simongravelle merged commit 37956ea into main Jan 27, 2025
@akohlmey akohlmey deleted the more-formatting-revisions branch January 27, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants