Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor of Zend\Db\Sql for 3.0.0 #19

Closed
weierophinney opened this issue Dec 31, 2019 · 7 comments
Closed

Refactor of Zend\Db\Sql for 3.0.0 #19

weierophinney opened this issue Dec 31, 2019 · 7 comments

Comments

@weierophinney
Copy link
Member

This is a task for refactoring Zend\Db\Sql using the type hints of PHP 7.2. You must work on the 3.0.0 branch.

If you change the API you should report it in the /3.0.0.md file.

Note: it's quite difficult to provide this code refactor without changing other classes. That means you should provide the refactoring without pass all the unit tests. In this phase is only important to have the unit tests running, so we you must focus only on fatal/parse errors.


Originally posted by @ezimuel at zendframework/zend-db#362

@weierophinney
Copy link
Member Author

I might take a look at it.


Originally posted by @guidofaecke at zendframework/zend-db#362 (comment)

@weierophinney
Copy link
Member Author

Thanks @guidofaecke, let me know if you need some help!


Originally posted by @ezimuel at zendframework/zend-db#362 (comment)

@weierophinney
Copy link
Member Author

@guidofaecke Do you want any assistance?


Originally posted by @arueckauer at zendframework/zend-db#362 (comment)

@weierophinney
Copy link
Member Author

You're more than welcome!

Here is what I got so far -> (https://github.com/guidofaecke/zend-db/tree/3.0.0_SQL_typeHints)
It's not a lot, I know, but I'm busy with some work related projects as well 😃


Originally posted by @guidofaecke at zendframework/zend-db#362 (comment)

@weierophinney
Copy link
Member Author

That's alright. Me working on a separate fork is unmanageable and PRs are overkill IMO. Would it be okay, if you grant me contribution access to your repo?


Originally posted by @arueckauer at zendframework/zend-db#362 (comment)

@weierophinney
Copy link
Member Author

Done... I think... 😆


Originally posted by @guidofaecke at zendframework/zend-db#362 (comment)

@weierophinney
Copy link
Member Author

This package is considered feature-complete, and is now in security-only maintenance mode, following a decision by the Technical Steering Committee.
If you have a security issue, please follow our security reporting guidelines.
If you wish to take on the role of maintainer, please nominate yourself

If you are looking for an actively maintained package alternative, we recommend:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant