-
-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor of Zend\Db\Sql
for 3.0.0
#19
Comments
I might take a look at it. Originally posted by @guidofaecke at zendframework/zend-db#362 (comment) |
Thanks @guidofaecke, let me know if you need some help! Originally posted by @ezimuel at zendframework/zend-db#362 (comment) |
@guidofaecke Do you want any assistance? Originally posted by @arueckauer at zendframework/zend-db#362 (comment) |
You're more than welcome! Here is what I got so far -> (https://github.com/guidofaecke/zend-db/tree/3.0.0_SQL_typeHints) Originally posted by @guidofaecke at zendframework/zend-db#362 (comment) |
That's alright. Me working on a separate fork is unmanageable and PRs are overkill IMO. Would it be okay, if you grant me contribution access to your repo? Originally posted by @arueckauer at zendframework/zend-db#362 (comment) |
Done... I think... 😆 Originally posted by @guidofaecke at zendframework/zend-db#362 (comment) |
|
This is a task for refactoring
Zend\Db\Sql
using the type hints of PHP 7.2. You must work on the 3.0.0 branch.If you change the API you should report it in the /3.0.0.md file.
Note: it's quite difficult to provide this code refactor without changing other classes. That means you should provide the refactoring without pass all the unit tests. In this phase is only important to have the unit tests running, so we you must focus only on fatal/parse errors.
Originally posted by @ezimuel at zendframework/zend-db#362
The text was updated successfully, but these errors were encountered: