Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken dependency constraints #19

Open
zluiten opened this issue Jan 15, 2021 · 0 comments
Open

Broken dependency constraints #19

zluiten opened this issue Jan 15, 2021 · 0 comments
Labels
Bug Something isn't working

Comments

@zluiten
Copy link
Contributor

zluiten commented Jan 15, 2021

Bug Report

Q A
Version(s) 2.*

Summary

The dependencies as configured in composer.json are not reliable since some dependencies that are required are actually only required as dev. The current state is that this package is not compatible with v4 of doctrine/doctrine-module. But there is no constraint that prevents that.

Current behavior

DoctrineModule v4 can be installed together with this package.

How to reproduce

Add this library as a dependency to a project that are requires v4 of doctrine/doctrine-module. Observe the signature mismatch of \DoctrineModule\Persistence\ObjectManagerAwareInterface inside \Laminas\ApiTools\Doctrine\Server\Query\Provider\AbstractQueryProvider.

Expected behavior

Move dev dependencies to required dependencies and lock supported versions.

@zluiten zluiten added the Bug Something isn't working label Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant