-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix grammar using typos #520
Conversation
WalkthroughThe pull request applies minor textual corrections across various Vim script files, documentation, and test specifications. Typos in error messages, comments, prompts, and test parameters are fixed, and additional logger constants are introduced. These changes do not alter the functional behavior or control flow of the system, serving only to improve clarity and consistency in the codebase and related documents. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
test/fern/helper.vimspec (1)
264-264
: LGTM! Consider extracting timeout options to a helper.The timeout key correction is good. Since this timeout configuration is used in multiple async tests, consider extracting it to a helper function to ensure consistency and make future maintenance easier.
Example helper function:
function! s:wait_with_timeout(promise) abort return Promise.wait(a:promise, { 'timeout': TIMEOUT }) endfunction
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (9)
autoload/fern/fri/from.vim
(1 hunks)autoload/fern/internal/buffer.vim
(1 hunks)autoload/fern/internal/node.vim
(1 hunks)autoload/fern/logger.vim
(1 hunks)autoload/fern/scheme/dict/mapping.vim
(1 hunks)doc/fern-develop.txt
(5 hunks)doc/fern.txt
(8 hunks)test/fern/helper.vimspec
(2 hunks)test/fern/hook.vimspec
(1 hunks)
✅ Files skipped from review due to trivial changes (8)
- autoload/fern/internal/node.vim
- autoload/fern/scheme/dict/mapping.vim
- autoload/fern/internal/buffer.vim
- test/fern/hook.vimspec
- autoload/fern/fri/from.vim
- doc/fern.txt
- autoload/fern/logger.vim
- doc/fern-develop.txt
🔇 Additional comments (1)
test/fern/helper.vimspec (1)
249-249
: LGTM! Important fix for test timeout.The correction of the timeout key is crucial as it ensures proper timeout handling in the asynchronous test. The previous typo could have led to tests hanging indefinitely if there were issues.
I noticed your latest commit and it had a type in it, so I fired up typos and found some more.
Also, there is a typo on a function itself:
Is it safe to rename the function too?
I noticed however, typos does not seem to catch all. E.g. directoty it did not detect.
Summary by CodeRabbit