This repository was archived by the owner on Jul 22, 2024. It is now read-only.
Add DECLARE and DEPLOY_ACCOUNT support to rpc_state_reader.
#995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: fmoletta <99273364+fmoletta@users.noreply.github.com>
…rust into FromStarknetApi
…rust into FromStarknetApi
…rust into FromStarknetApi
Oppen
approved these changes
Sep 6, 2023
juanbono
approved these changes
Sep 8, 2023
Oppen
approved these changes
Sep 8, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
juanbono
approved these changes
Sep 12, 2023
Oppen
reviewed
Sep 18, 2023
rpc_state_reader/tests/sir_tests.rs
Outdated
| @@ -138,7 +134,10 @@ pub fn execute_tx( | |||
|
|
|||
| // Get transaction before giving ownership of the reader | |||
| let tx_hash = TransactionHash(stark_felt!(tx_hash)); | |||
| let tx = match rpc_reader.0.get_transaction(&tx_hash) { | |||
| let tx = match dbg!(rpc_reader.0.get_transaction(&tx_hash)) { | |||
There was a problem hiding this comment.
I think we can drop the dbg!.
Oppen
reviewed
Sep 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add DECLARE and DEPLOY_ACCOUNT support to rpc_state_reader
Description
Depends on #967 (well, it contains it rather than depends on).
Add support for the following transaction types to
rpc_state_reader:DECLARE(v1)DECLARE(v2)DEPLOYDEPLOY_ACCOUNTChecklist