fix: Felt serde #883
Merged
fix: Felt serde #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #883 +/- ##
=======================================
Coverage 72.05% 72.05%
=======================================
Files 149 149
Lines 33408 33408
=======================================
Hits 24073 24073
Misses 9335 9335 ☔ View full report in Codecov by Sentry. |
Oppen
approved these changes
Jul 22, 2024
|
Can we add the examples to the compile pipeline? |
igamigo
commented
Jul 22, 2024
| @@ -11,7 +11,7 @@ path = "src/main.rs" | |||
|
|
|||
| [dependencies] | |||
| clap = { version = "4.4.6", features = ["derive"] } | |||
| lambdaworks-crypto = { workspace = true } | |||
| lambdaworks-crypto = { workspace = true, features = ["serde"]} | |||
There was a problem hiding this comment.
This came up when building all other examples. The crate relies on serde and it fails to compile if it's not added.
Oppen
approved these changes
Jul 22, 2024
diegokingston
approved these changes
Aug 5, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
@igamigo it seems the compiler updated and now there are new lints. The failing pipelines are due to missing indentation in some doc comments in the fft implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Felt serde fix
(Tested with Rust 1.79)
The
prove-midenexample was not compiling correctly due to a serde problem withFieldElement.Description
Fixes compilation by making the type explicit to
&strso that the type is Sized and it does not fail based on the serde bounds.To repro the problem on
main:cd examples/prove-miden && cargo runType of change
Checklist