feat: turn Poseidon parameters into trait #706
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than having the parameters as internal state, we consider them to be compile time constants, and implement them via stateless structures with associated constants, which in turn implement the `PermutationParameters` trait. We use a seal trait for the actual code to avoid overriding methods by mistake. This is the `Poseidon` trait. It's automatically implemented for all implementors of `PermutationParameters`.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #706 +/- ##
==========================================
+ Coverage 96.26% 96.29% +0.03%
==========================================
Files 130 130
Lines 29734 29660 -74
==========================================
- Hits 28623 28562 -61
+ Misses 1111 1098 -13 ☔ View full report in Codecov by Sentry. |
MauroToscano
approved these changes
Dec 4, 2023
entropidelic
approved these changes
Dec 4, 2023
diegokingston
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than having the parameters as internal state, we consider them to
be compile time constants, and implement them via stateless structures
with associated constants, which in turn implement the
PermutationParameterstrait.We use a seal trait for the actual code to avoid overriding methods by
mistake. This is the
Poseidontrait. It's automatically implementedfor all implementors of
PermutationParameters.Type of change
Checklist