Fix bincode repo change (#1023)

* Fix bincode inclusion

* Add feature serde

* fix clippy

* fix warnings in benches and solve bincode dependency

* use crates io for bincode

---------

Co-authored-by: jotabulacios <jbulacios@fi.uba.ar>

Author: pablodeymo

Cargo.toml

@@ -53,6 +53,7 @@ winter-math = { git = "https://github.com/lambdaclass/winterfell-for-lambdaworks
 winter-utils = { git = "https://github.com/lambdaclass/winterfell-for-lambdaworks.git", branch = "derive-clone-v6.4" }
 winter-crypto = { git = "https://github.com/lambdaclass/winterfell-for-lambdaworks.git", branch = "derive-clone-v6.4" }
 
+
 [profile.bench]
 lto = true
 codegen-units = 1

crates/crypto/src/commitments/kzg.rs

@@ -276,6 +276,7 @@ impl<const N: usize, F: IsPrimeField<RepresentativeType = UnsignedInteger<N>>, P
 #[cfg(test)]
 mod tests {
     use alloc::vec::Vec;
+    use core::slice;
     use lambdaworks_math::{
         cyclic_group::IsGroup,
         elliptic_curve::{
@@ -367,7 +368,7 @@ mod tests {
         let y0 = FieldElement::from(9000);
         let upsilon = &FieldElement::from(1);
 
-        let proof = kzg.open_batch(&x, &[y0.clone()], &[p0], upsilon);
+        let proof = kzg.open_batch(&x, slice::from_ref(&y0), &[p0], upsilon);
 
         assert!(kzg.verify_batch(&x, &[y0], &[p0_commitment], &proof, upsilon));
     }

crates/math/benches/fields/baby_bear.rs

@@ -357,7 +357,7 @@ pub fn babybear_p3_ops_benchmarks(c: &mut Criterion) {
         group.bench_with_input(format!("Addition {:?}", &i.len()), &i, |bench, i| {
             bench.iter(|| {
                 for (x, y) in i {
-                    black_box(black_box(*x) + black_box(*y));
+                    let _ = black_box(black_box(*x) + black_box(*y));
                 }
             });
         });
@@ -367,7 +367,7 @@ pub fn babybear_p3_ops_benchmarks(c: &mut Criterion) {
         group.bench_with_input(format!("Multiplication {:?}", &i.len()), &i, |bench, i| {
             bench.iter(|| {
                 for (x, y) in i {
-                    black_box(black_box(*x) * black_box(*y));
+                    let _ = black_box(black_box(*x) * black_box(*y));
                 }
             });
         });
@@ -377,7 +377,7 @@ pub fn babybear_p3_ops_benchmarks(c: &mut Criterion) {
         group.bench_with_input(format!("Square {:?}", &i.len()), &i, |bench, i| {
             bench.iter(|| {
                 for (x, _) in i {
-                    black_box(black_box(x).square());
+                    let _ = black_box(black_box(x).square());
                 }
             });
         });
@@ -386,7 +386,7 @@ pub fn babybear_p3_ops_benchmarks(c: &mut Criterion) {
         group.bench_with_input(format!("Inverse {:?}", &i.len()), &i, |bench, i| {
             bench.iter(|| {
                 for (x, _) in i {
-                    black_box(black_box(x).inverse());
+                    let _ = black_box(black_box(x).inverse());
                 }
             });
         });
@@ -396,7 +396,7 @@ pub fn babybear_p3_ops_benchmarks(c: &mut Criterion) {
         group.bench_with_input(format!("Division {:?}", &i.len()), &i, |bench, i| {
             bench.iter(|| {
                 for (x, y) in i {
-                    black_box(black_box(*x) / black_box(*y));
+                    let _ = black_box(black_box(*x) / black_box(*y));
                 }
             });
         });
@@ -416,7 +416,7 @@ pub fn babybear_extension_ops_benchmarks_p3(c: &mut Criterion) {
         group.bench_with_input(format!("Addition of Fp4 {:?}", &i.len()), &i, |bench, i| {
             bench.iter(|| {
                 for (x, y) in i {
-                    black_box(black_box(*x) + black_box(*y));
+                    let _ = black_box(black_box(*x) + black_box(*y));
                 }
             });
         });
@@ -428,7 +428,7 @@ pub fn babybear_extension_ops_benchmarks_p3(c: &mut Criterion) {
             |bench, i| {
                 bench.iter(|| {
                     for (x, y) in i {
-                        black_box(black_box(*x) * black_box(*y));
+                        let _ = black_box(black_box(*x) * black_box(*y));
                     }
                 });
             },
@@ -438,7 +438,7 @@ pub fn babybear_extension_ops_benchmarks_p3(c: &mut Criterion) {
         group.bench_with_input(format!("Square of Fp4 {:?}", &i.len()), &i, |bench, i| {
             bench.iter(|| {
                 for (x, _) in i {
-                    black_box(black_box(x).square());
+                    let _ = black_box(black_box(x).square());
                 }
             });
         });
@@ -448,7 +448,7 @@ pub fn babybear_extension_ops_benchmarks_p3(c: &mut Criterion) {
         group.bench_with_input(format!("Inverse of Fp4 {:?}", &i.len()), &i, |bench, i| {
             bench.iter(|| {
                 for (x, _) in i {
-                    black_box(black_box(x).inverse());
+                    let _ = black_box(black_box(x).inverse());
                 }
             });
         });
@@ -458,7 +458,7 @@ pub fn babybear_extension_ops_benchmarks_p3(c: &mut Criterion) {
         group.bench_with_input(format!("Division of Fp4 {:?}", &i.len()), &i, |bench, i| {
             bench.iter(|| {
                 for (x, y) in i {
-                    black_box(black_box(*x) / black_box(*y));
+                    let _ = black_box(black_box(*x) / black_box(*y));
                 }
             });
         });

crates/math/src/polynomial/mod.rs

@@ -2,7 +2,7 @@ use super::field::element::FieldElement;
 use crate::field::traits::{IsField, IsPrimeField, IsSubFieldOf};
 use alloc::string::{String, ToString};
 use alloc::{borrow::ToOwned, format, vec, vec::Vec};
-use core::{fmt::Display, ops};
+use core::{fmt::Display, ops, slice};
 pub mod dense_multilinear_poly;
 mod error;
 pub mod sparse_multilinear_poly;
@@ -79,7 +79,7 @@ impl<F: IsField> Polynomial<FieldElement<F>> {
         let mut result = Polynomial::zero();
 
         for (i, y) in ys.iter().enumerate() {
-            let mut y_term = Polynomial::new(&[y.clone()]);
+            let mut y_term = Polynomial::new(slice::from_ref(y));
             for (j, x) in xs.iter().enumerate() {
                 if i == j {
                     continue;

crates/provers/stark/Cargo.toml

@@ -20,7 +20,7 @@ miden-core = { git = "https://github.com/lambdaclass/miden-vm", optional = true
 rand = "0.8.5"
 thiserror = "1.0.38"
 log = "0.4.17"
-bincode = { version = "2.0.0-rc.2", tag = "v2.0.0-rc.2", git = "https://github.com/bincode-org/bincode.git" }
+bincode = { version = "2.0.1", features = ["serde"] }
 sha3 = "0.10.6"
 serde = { version = "1.0", features = ["derive"] }
 serde_json = "1.0"

examples/merkle-tree-cli/Cargo.toml

@@ -11,8 +11,8 @@ path = "src/main.rs"
 
 [dependencies]
 clap = { version = "4.4.6", features = ["derive"] }
-lambdaworks-crypto = { workspace = true, features = ["serde"]}
+lambdaworks-crypto = { workspace = true, features = ["serde"] }
 lambdaworks-math = { workspace = true, features = ["lambdaworks-serde-string"] }
 serde = { version = "1.0" }
 serde_json = "1"
-bincode = { version = "2.0.0-rc.2", tag = "v2.0.0-rc.2", git = "https://github.com/bincode-org/bincode.git", features= ['serde'] }
+bincode = { version = "2.0.1", features = ["serde"] }

examples/prove-miden/Cargo.toml

@@ -13,13 +13,15 @@ path = "src/main.rs"
 lambdaworks-crypto = { workspace = true }
 lambdaworks-math = { workspace = true, features = ["lambdaworks-serde-string"] }
 lambdaworks-winterfell-adapter = { workspace = true }
-stark-platinum-prover = { git = "https://github.com/lambdaclass/lambdaworks" , branch = "miden-version", features = ["winter_compatibility"] }
+stark-platinum-prover = { git = "https://github.com/lambdaclass/lambdaworks", branch = "miden-version", features = [
+    "winter_compatibility",
+] }
 
 serde = { version = "1.0" }
 serde_json = "1"
-bincode = { version = "2.0.0-rc.2", tag = "v2.0.0-rc.2", git = "https://github.com/bincode-org/bincode.git", features= ['serde'] }
-miden-core = { package = "miden-core" , version = "0.7"}
+bincode = { version = "2.0.1", features = ["serde"] }
+miden-core = { package = "miden-core", version = "0.7" }
 miden-assembly = { package = "miden-assembly", version = "0.7" }
 miden-processor = { package = "miden-processor", version = "0.7" }
-miden-air = { package = "miden-air", version = "0.7"}
+miden-air = { package = "miden-air", version = "0.7" }
 winter-prover = { package = "winter-prover", version = "0.6.4" }