feat(l2): blockchain tests stateless execution #3076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lines of code reportTotal lines added: Detailed view |
Benchmark for c7431d1Click to view benchmark
|
LeanSerra
changed the title
Benchmark for 1f369e1Click to view benchmark
|
Benchmark for ed360e9Click to view benchmark
|
Base automatically changed from
feat/debug_executionWitness_2
to
feat/debug_executionWitness_3
June 6, 2025 22:18
Benchmark for 086f8cbClick to view benchmark
|
Benchmark for 27dbea6Click to view benchmark
|
Benchmark for d11c7e9Click to view benchmark
|
xqft
reviewed
Jun 9, 2025
crates/common/trie/trie.rs
Outdated
Comment on lines
396
to
402
| pub fn root_node(&self) -> Result<Option<Node>, TrieError> { | ||
| self.root.get_node(self.db.as_ref()) | ||
| if self.root.compute_hash().finalize() == *EMPTY_TRIE_HASH { | ||
| self.root.get_node(self.db.as_ref()) | ||
| } else { | ||
| Ok(None) | ||
| } | ||
| } |
There was a problem hiding this comment.
Nice catch fixed here
iovoid
reviewed
Jun 9, 2025
Comment on lines
+267
to
+269
| assert!(test_should_fail, "Expected test to succeed failed with {e}") | ||
| } else { | ||
| assert!(!test_should_fail, "Expected test to fail succeeded") |
There was a problem hiding this comment.
Maybe include the test name in the error message?
Benchmark for a499d1fClick to view benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to run the ef state tests with our prover with stateless execution
Description
Fixes:
Ok(None)forTrie::root_nodevalidate_receiptsandvalidate_requests_hashto stateless executionblock.body.withdrawalswhen generating the witnessHow to test
cd cmd/ef_tests/blockchain