feat(l1, l2): storage commit change #3043
Open
+389
−183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Juan Bono <juanbono94@gmail.com>
Lines of code reportTotal lines added: Detailed view |
Benchmark for 9f8b7aeClick to view benchmark
|
Benchmark for 32ea549Click to view benchmark
|
Benchmark for 5ff126bClick to view benchmark
|
Benchmark for 8eb61a4Click to view benchmark
|
mpaulucci
reviewed
Jun 5, 2025
| .storage | ||
| .apply_account_updates_batch(block.header.parent_hash, account_updates) | ||
| .await? | ||
| .ok_or(ChainError::ParentStateNotFound)?; |
There was a problem hiding this comment.
is this the only error possible? I think this might be misleading
Benchmark for c738ad6Click to view benchmark
|
Benchmark for 3b8d26fClick to view benchmark
|
…ases (#3072) **Motivation** Original PR was missing ReDB and InMemory implementations. **Description** Merges the single-update method as a special case of the batch one. Part of #3043 --------- Co-authored-by: Juan Bono <juanbono94@gmail.com> Co-authored-by: Ivan Litteri <67517699+ilitteri@users.noreply.github.com>
MegaRedHand
reviewed
Jun 9, 2025
Comment on lines
+365
to
+369
| ( | ||
| H256, | ||
| Vec<(NodeHash, Vec<u8>)>, | ||
| Vec<(H256, Vec<(NodeHash, Vec<u8>)>)>, | ||
| ), |
There was a problem hiding this comment.
This return type requires documentation, and I suggest declaring it outside the function, possibly as a struct.
Benchmark for f8d90b4Click to view benchmark
|
Benchmark for 57197dfClick to view benchmark
|
Benchmark for e2c8607Click to view benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR modifies the insert strategy to make the commits at the end of the block instead of doing them on every transaction.
Description
Closes #issue_number