refactor(l2): rewrite integration tests #2681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lines of code reportTotal lines added: Detailed view |
ilitteri
approved these changes
May 6, 2025
ilitteri
changed the title
jrchatruc
approved these changes
May 8, 2025
pedrobergamini
pushed a commit
to pedrobergamini/ethrex
that referenced
this pull request
Aug 24, 2025
**Motivation** <!-- Why does this pull request exist? What are its goals? --> L2 tests were broken since two tests were waiting for funds in L2 without depositing. **Description** - Adds `test_deposit`, `test_transfer`, `test_withdraw`, `test_deploy`, `test_call_with_deposit` functions that are used by all the tests. - The deposits and transfers are now done from an L1 rich wallet to a random L2 wallet. - Adds `L1ToL2TransactionData` struct to the SDK. This struct contains the current L2 data for privileged transactions. - Adds `send_l1_to_l2_transaction` function to the SDK. - Adds `deposit_through_contract_call` function to the SDK (wrapper over the above). --------- Co-authored-by: ilitteri <ilitteri@fi.uba.ar>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
L2 tests were broken since two tests were waiting for funds in L2 without depositing.
Description
test_deposit,test_transfer,test_withdraw,test_deploy,test_call_with_depositfunctions that are used by all the tests.L1ToL2TransactionDatastruct to the SDK. This struct contains the current L2 data for privileged transactions.send_l1_to_l2_transactionfunction to the SDK.deposit_through_contract_callfunction to the SDK (wrapper over the above).