Skip to content

Commit 7097369

Browse files
Peter JohnsonPeter Johnson
authored andcommitted
Added test requirement for deployment
1 parent 2ad91fe commit 7097369

File tree

2 files changed

+9
-7
lines changed

2 files changed

+9
-7
lines changed

.github/workflows/production-deploy.yml

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ on:
44
workflow_dispatch:
55
inputs:
66
version-bump:
7-
description: 'Version bump type'
7+
description: "Version bump type"
88
required: true
99
type: choice
1010
options:
@@ -13,10 +13,10 @@ on:
1313
- major
1414
default: patch
1515
branch:
16-
description: 'Branch to release from'
16+
description: "Branch to release from"
1717
required: true
1818
type: string
19-
default: 'main'
19+
default: "main"
2020
jobs:
2121
test:
2222
name: Test
@@ -29,7 +29,7 @@ jobs:
2929
strategy:
3030
fail-fast: false
3131
matrix:
32-
python-version: [ "3.12" ]
32+
python-version: ["3.12"]
3333
steps:
3434
- name: Checkout
3535
uses: actions/checkout@v4
@@ -90,10 +90,11 @@ jobs:
9090
path: ./reports/pytest.xml
9191
if-no-files-found: warn
9292
deploy:
93+
needs: test
9394
uses: lambda-feedback/evaluation-function-workflows/.github/workflows/deploy.yml@deploy-request
9495
with:
9596
template-repository-name: "lambda-feedback/evaluation-function-boilerplate-python"
96-
build-platforms: 'aws'
97+
build-platforms: "aws"
9798
environment: "production"
9899
version-bump: ${{ inputs.version-bump }}
99100
branch: ${{ inputs.branch }}

.github/workflows/staging-deploy.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
strategy:
2020
fail-fast: false
2121
matrix:
22-
python-version: [ "3.12" ]
22+
python-version: ["3.12"]
2323
steps:
2424
- name: Checkout
2525
uses: actions/checkout@v4
@@ -80,10 +80,11 @@ jobs:
8080
path: ./reports/pytest.xml
8181
if-no-files-found: warn
8282
deploy:
83+
needs: test
8384
uses: lambda-feedback/evaluation-function-workflows/.github/workflows/deploy.yml@deploy-request
8485
with:
8586
template-repository-name: "lambda-feedback/evaluation-function-boilerplate-python"
86-
build-platforms: 'aws'
87+
build-platforms: "aws"
8788
environment: "staging"
8889
secrets:
8990
aws-key-id: ${{ secrets.LAMBDA_CONTAINER_PIPELINE_AWS_ID }}

0 commit comments

Comments
 (0)