Search Service loses events

[ignasi35]

When running the application on a clean environment, if elasticsearch is not running and a user creates an item then that item will not be searchable.

Steps to reproduce:

• run the app (make sure the elasticsearch DB is not running)
• create a user "bob" and with that create an item "chair" with a time to auction of 1 day and start the auction
• wait few seconds
• make sure the elasticsearch data/ folder is empty so that no index with previous data exists and start elasticsearch
• using "bob" create an item "car" with a time to auction of 1 day and start the auction
• go to "search" in the top right corner of the screen and search "chair" and then search "car"

Expected:

• each search returns the item under auction

Actual:

• only "car" is returned

Comments:

I haven't tracked down all possible scenarios where this issue happens. Here's some suspicions that can help narrow the cases:

• only happens when the Elasticsearch index doesn't exist.
• only the item-service or the bid-events messages from kafka are lost (I highly doubt that since search-service reuses a lot of code to consume from both topics)
• the error is not propagating the storage failure from here to here so events are marked as consumed in kafka