From 6dc2b4b34fbee9f44c043a63c97a4ae8862d8b08 Mon Sep 17 00:00:00 2001 From: Yuliana Apaza Date: Thu, 1 Jun 2017 20:03:37 -0500 Subject: [PATCH] Add test shouldEmitEventWhenSubmittingDeliveryDetails --- .../transaction/api/TransactionService.java | 3 +-- .../impl/TransactionEntityTest.java | 21 +++++++++++++++---- 2 files changed, 18 insertions(+), 6 deletions(-) diff --git a/transaction-api/src/main/java/com/example/auction/transaction/api/TransactionService.java b/transaction-api/src/main/java/com/example/auction/transaction/api/TransactionService.java index 4c2f9ec..b6233ec 100644 --- a/transaction-api/src/main/java/com/example/auction/transaction/api/TransactionService.java +++ b/transaction-api/src/main/java/com/example/auction/transaction/api/TransactionService.java @@ -48,8 +48,7 @@ default Descriptor descriptor() { return named("transaction").withCalls( pathCall("/api/item/:id/transaction", this::submitDeliveryDetails) ).withPathParamSerializer(UUID.class, PathParamSerializers.required("UUID", UUID::fromString, UUID::toString)) - .withHeaderFilter(SecurityHeaderFilter.INSTANCE) - .withAutoAcl(true); + .withHeaderFilter(SecurityHeaderFilter.INSTANCE); } diff --git a/transaction-impl/src/test/java/com/example/auction/transaction/impl/TransactionEntityTest.java b/transaction-impl/src/test/java/com/example/auction/transaction/impl/TransactionEntityTest.java index 859b7f4..d283713 100644 --- a/transaction-impl/src/test/java/com/example/auction/transaction/impl/TransactionEntityTest.java +++ b/transaction-impl/src/test/java/com/example/auction/transaction/impl/TransactionEntityTest.java @@ -7,11 +7,11 @@ import com.example.auction.transaction.impl.TransactionCommand.*; import com.example.auction.transaction.impl.TransactionEvent.*; + import java.util.Optional; import java.util.UUID; -import static org.hamcrest.CoreMatchers.equalTo; -import static org.hamcrest.CoreMatchers.hasItem; +import static org.hamcrest.CoreMatchers.*; import static org.junit.Assert.assertThat; import static org.junit.Assert.fail; @@ -34,9 +34,13 @@ public static void shutdownActorSystem() { private final UUID itemId = UUID.randomUUID(); private final UUID creator = UUID.randomUUID(); private final UUID winner = UUID.randomUUID(); + private final DeliveryData deliveryData = new DeliveryData("Addr1", "Addr2", "City", "State", 27, "Country"); private final Transaction transaction = new Transaction(itemId, creator, winner, 2000); + private final StartTransaction startTransaction = new StartTransaction(transaction); + private final SubmitDeliveryDetails submitDeliveryDetails = new SubmitDeliveryDetails(creator, deliveryData); + @Before public void createTestDriver() { driver = new PersistentEntityTestDriver<>(system, new TransactionEntity(), itemId.toString()); @@ -51,11 +55,20 @@ public void noIssues() { } @Test - public void testStartTransaction() { - PersistentEntityTestDriver.Outcome outcome = driver.run(new StartTransaction(transaction)); + public void shouldEmitEvenWhenCreatingTransaction() { + PersistentEntityTestDriver.Outcome outcome = driver.run(startTransaction); assertThat(outcome.state().getStatus(), equalTo(TransactionStatus.NEGOTIATING_DELIVERY)); assertThat(outcome.state().getTransaction(), equalTo(Optional.of(transaction))); assertThat(outcome.events(), hasItem(new TransactionStarted(itemId, transaction))); } + + @Test + public void shouldEmitEventWhenSubmittingDeliveryDetails(){ + driver.run(startTransaction); + PersistentEntityTestDriver.Outcome outcome = driver.run(submitDeliveryDetails); + assertThat(outcome.state().getStatus(), equalTo(TransactionStatus.NEGOTIATING_DELIVERY)); + assertThat(outcome.events(), hasItem(new DeliveryDetailsSubmitted(itemId, deliveryData))); + } } +